[PATCH] char: agp: intel-agp: check the return value of pci_find_capability()

Jia-Ju Bai posted 1 patch 4 years, 3 months ago
drivers/char/agp/intel-agp.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] char: agp: intel-agp: check the return value of pci_find_capability()
Posted by Jia-Ju Bai 4 years, 3 months ago
The function pci_find_capability() in agp_intel_probe() can fail, so its
return value should be checked.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/char/agp/intel-agp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 9e4f27a6cb5a..6a7e385bde8a 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -730,6 +730,8 @@ static int agp_intel_probe(struct pci_dev *pdev,
 	int i, err;
 
 	cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP);
+	if (!cap_ptr)
+		return -ENODEV;
 
 	bridge = agp_alloc_bridge();
 	if (!bridge)
-- 
2.17.1