Documentation/locking/locktypes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
With PREEMPT_RT the _bh() version of a spinlock leaves preemption
enabled, align the doc to say that instead of the opposite.
Reported-by: Leah Leshchinsky <lleshchi@redhat.com>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Documentation/locking/locktypes.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
index 4fd7b70fcde1..bfa75ea1b66a 100644
--- a/Documentation/locking/locktypes.rst
+++ b/Documentation/locking/locktypes.rst
@@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
Non-PREEMPT_RT kernels disable preemption to get this effect.
PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
- preemption disabled. The lock disables softirq handlers and also
+ preemption enabled. The lock disables softirq handlers and also
prevents reentrancy due to task preemption.
PREEMPT_RT kernels preserve all other spinlock_t semantics:
--
2.35.1
On Thu, Feb 24, 2022 at 03:23:12PM -0600, Andrew Halaney wrote: > With PREEMPT_RT the _bh() version of a spinlock leaves preemption > enabled, align the doc to say that instead of the opposite. > > Reported-by: Leah Leshchinsky <lleshchi@redhat.com> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Regards, Boqun > --- > Documentation/locking/locktypes.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst > index 4fd7b70fcde1..bfa75ea1b66a 100644 > --- a/Documentation/locking/locktypes.rst > +++ b/Documentation/locking/locktypes.rst > @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics: > Non-PREEMPT_RT kernels disable preemption to get this effect. > > PREEMPT_RT kernels use a per-CPU lock for serialization which keeps > - preemption disabled. The lock disables softirq handlers and also > + preemption enabled. The lock disables softirq handlers and also > prevents reentrancy due to task preemption. > > PREEMPT_RT kernels preserve all other spinlock_t semantics: > -- > 2.35.1 >
Andrew Halaney <ahalaney@redhat.com> writes: > With PREEMPT_RT the _bh() version of a spinlock leaves preemption > enabled, align the doc to say that instead of the opposite. > > Reported-by: Leah Leshchinsky <lleshchi@redhat.com> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > Documentation/locking/locktypes.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst > index 4fd7b70fcde1..bfa75ea1b66a 100644 > --- a/Documentation/locking/locktypes.rst > +++ b/Documentation/locking/locktypes.rst > @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics: > Non-PREEMPT_RT kernels disable preemption to get this effect. > > PREEMPT_RT kernels use a per-CPU lock for serialization which keeps > - preemption disabled. The lock disables softirq handlers and also > + preemption enabled. The lock disables softirq handlers and also > prevents reentrancy due to task preemption. Applied, thanks. jon
© 2016 - 2026 Red Hat, Inc.