[PATCH] scsi: qla4xxx: Remove unneeded variable

cgel.zte@gmail.com posted 1 patch 4 years, 3 months ago
drivers/scsi/qla4xxx/ql4_os.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] scsi: qla4xxx: Remove unneeded variable
Posted by cgel.zte@gmail.com 4 years, 3 months ago
From: Changcheng Deng <deng.changcheng@zte.com.cn>

Remove unneeded variable used to store return value.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/scsi/qla4xxx/ql4_os.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index d64eda961412..b49c38416fb9 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -3640,7 +3640,6 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *sess,
 				       struct dev_db_entry *fw_ddb_entry)
 {
 	uint16_t options;
-	int rc = 0;
 
 	options = le16_to_cpu(fw_ddb_entry->options);
 	SET_BITVAL(conn->is_fw_assigned_ipv6,  options, BIT_11);
@@ -3739,7 +3738,7 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *sess,
 
 	COPY_ISID(fw_ddb_entry->isid, sess->isid);
 
-	return rc;
+	return 0;
 }
 
 static void qla4xxx_copy_to_sess_conn_params(struct iscsi_conn *conn,
-- 
2.25.1

Re: [PATCH] scsi: qla4xxx: Remove unneeded variable
Posted by Martin K. Petersen 4 years, 3 months ago
On Thu, 24 Feb 2022 09:07:35 +0000, cgel.zte@gmail.com wrote:

> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Remove unneeded variable used to store return value.
> 
> 

Applied to 5.18/scsi-queue, thanks!

[1/1] scsi: qla4xxx: Remove unneeded variable
      https://git.kernel.org/mkp/scsi/c/c13ad4cf6de8

-- 
Martin K. Petersen	Oracle Linux Engineering