habanalabs: Add check for pci_enable_device

[PATCH] habanalabs: Add check for pci_enable_device

Posted by Jiasheng Jiang 4 years, 3 months ago

As the potential failure of the pci_enable_device(),
it should be better to check the return value and return
error if fails.

Fixes: 70b2f993ea4a ("habanalabs: create common folder")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/misc/habanalabs/common/debugfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c
index fc084ee5106e..09001fd9db85 100644
--- a/drivers/misc/habanalabs/common/debugfs.c
+++ b/drivers/misc/habanalabs/common/debugfs.c
@@ -890,6 +890,8 @@ static ssize_t hl_set_power_state(struct file *f, const char __user *buf,
 		pci_set_power_state(hdev->pdev, PCI_D0);
 		pci_restore_state(hdev->pdev);
 		rc = pci_enable_device(hdev->pdev);
+		if (rc < 0)
+			return rc;
 	} else if (value == 2) {
 		pci_save_state(hdev->pdev);
 		pci_disable_device(hdev->pdev);
-- 
2.25.1

Re: [PATCH] habanalabs: Add check for pci_enable_device

Posted by Oded Gabbay 4 years, 3 months ago

On Thu, Feb 24, 2022 at 8:58 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
>
> As the potential failure of the pci_enable_device(),
> it should be better to check the return value and return
> error if fails.
>
> Fixes: 70b2f993ea4a ("habanalabs: create common folder")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/misc/habanalabs/common/debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c
> index fc084ee5106e..09001fd9db85 100644
> --- a/drivers/misc/habanalabs/common/debugfs.c
> +++ b/drivers/misc/habanalabs/common/debugfs.c
> @@ -890,6 +890,8 @@ static ssize_t hl_set_power_state(struct file *f, const char __user *buf,
>                 pci_set_power_state(hdev->pdev, PCI_D0);
>                 pci_restore_state(hdev->pdev);
>                 rc = pci_enable_device(hdev->pdev);
> +               if (rc < 0)
> +                       return rc;
>         } else if (value == 2) {
>                 pci_save_state(hdev->pdev);
>                 pci_disable_device(hdev->pdev);
> --
> 2.25.1
>
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded