[PATCH v2] arm64: defconfig: Enable configs for DisplayPort on J721e

Rahul T R posted 1 patch 4 years, 4 months ago
There is a newer version of this series
arch/arm64/configs/defconfig | 4 ++++
1 file changed, 4 insertions(+)
[PATCH v2] arm64: defconfig: Enable configs for DisplayPort on J721e
Posted by Rahul T R 4 years, 4 months ago
Enable DRM and PHY configs required for supporting
DisplayPort on J721e

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
---

Notes:
    v2:
    	Fixed the places using savedefconfig
    	Added more info in notes
    
    No change in vmlinux:
    
    	add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
    	Function                                     old     new   delta
    	Total: Before=24042991, After=24042991, chg +0.00%
    
    Diffstat of bootlogs:
    
    	after_boot.log |   46 ++++++++++++++++++++++++++--------------------
    	1 file changed, 26 insertions(+), 20 deletions(-)

 arch/arm64/configs/defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 9f23d7ec1232..56d4c126f6da 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -736,6 +736,7 @@ CONFIG_DRM_THINE_THC63LVD1024=m
 CONFIG_DRM_TI_SN65DSI86=m
 CONFIG_DRM_I2C_ADV7511=m
 CONFIG_DRM_I2C_ADV7511_AUDIO=y
+CONFIG_DRM_CDNS_MHDP8546=m
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_DW_HDMI_CEC=m
 CONFIG_DRM_IMX_DCSS=m
@@ -750,6 +751,7 @@ CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
 CONFIG_DRM_LIMA=m
 CONFIG_DRM_PANFROST=m
+CONFIG_DRM_TIDSS=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_EFI=y
@@ -1151,6 +1153,7 @@ CONFIG_RESET_RZG2L_USBPHY_CTRL=y
 CONFIG_RESET_TI_SCI=y
 CONFIG_PHY_XGENE=y
 CONFIG_PHY_SUN4I_USB=y
+CONFIG_PHY_CADENCE_TORRENT=m
 CONFIG_PHY_MIXEL_MIPI_DPHY=m
 CONFIG_PHY_FSL_IMX8M_PCIE=y
 CONFIG_PHY_HI6220_USB=y
@@ -1175,6 +1178,7 @@ CONFIG_PHY_SAMSUNG_UFS=y
 CONFIG_PHY_UNIPHIER_USB2=y
 CONFIG_PHY_UNIPHIER_USB3=y
 CONFIG_PHY_TEGRA_XUSB=y
+CONFIG_PHY_J721E_WIZ=m
 CONFIG_ARM_SMMU_V3_PMU=m
 CONFIG_FSL_IMX8_DDR_PMU=m
 CONFIG_QCOM_L2_PMU=y
-- 
2.17.1

Re: [PATCH v2] arm64: defconfig: Enable configs for DisplayPort on J721e
Posted by Tomi Valkeinen 4 years, 3 months ago
On 23/02/2022 12:15, Rahul T R wrote:
> Enable DRM and PHY configs required for supporting
> DisplayPort on J721e
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
> 
> Notes:
>      v2:
>      	Fixed the places using savedefconfig
>      	Added more info in notes
>      
>      No change in vmlinux:
>      
>      	add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
>      	Function                                     old     new   delta
>      	Total: Before=24042991, After=24042991, chg +0.00%
>      
>      Diffstat of bootlogs:
>      
>      	after_boot.log |   46 ++++++++++++++++++++++++++--------------------
>      	1 file changed, 26 insertions(+), 20 deletions(-)
> 
>   arch/arm64/configs/defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 9f23d7ec1232..56d4c126f6da 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -736,6 +736,7 @@ CONFIG_DRM_THINE_THC63LVD1024=m
>   CONFIG_DRM_TI_SN65DSI86=m
>   CONFIG_DRM_I2C_ADV7511=m
>   CONFIG_DRM_I2C_ADV7511_AUDIO=y
> +CONFIG_DRM_CDNS_MHDP8546=m
>   CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
>   CONFIG_DRM_DW_HDMI_CEC=m
>   CONFIG_DRM_IMX_DCSS=m
> @@ -750,6 +751,7 @@ CONFIG_DRM_MESON=m
>   CONFIG_DRM_PL111=m
>   CONFIG_DRM_LIMA=m
>   CONFIG_DRM_PANFROST=m
> +CONFIG_DRM_TIDSS=m
>   CONFIG_FB=y
>   CONFIG_FB_MODE_HELPERS=y
>   CONFIG_FB_EFI=y
> @@ -1151,6 +1153,7 @@ CONFIG_RESET_RZG2L_USBPHY_CTRL=y
>   CONFIG_RESET_TI_SCI=y
>   CONFIG_PHY_XGENE=y
>   CONFIG_PHY_SUN4I_USB=y
> +CONFIG_PHY_CADENCE_TORRENT=m
>   CONFIG_PHY_MIXEL_MIPI_DPHY=m
>   CONFIG_PHY_FSL_IMX8M_PCIE=y
>   CONFIG_PHY_HI6220_USB=y
> @@ -1175,6 +1178,7 @@ CONFIG_PHY_SAMSUNG_UFS=y
>   CONFIG_PHY_UNIPHIER_USB2=y
>   CONFIG_PHY_UNIPHIER_USB3=y
>   CONFIG_PHY_TEGRA_XUSB=y
> +CONFIG_PHY_J721E_WIZ=m
>   CONFIG_ARM_SMMU_V3_PMU=m
>   CONFIG_FSL_IMX8_DDR_PMU=m
>   CONFIG_QCOM_L2_PMU=y

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Not directly related to this patch, but this is slightly annoying:

cdns-mhdp8546 a000000.dp-bridge: invalid resource
cdns-mhdp8546 a000000.dp-bridge: Failed to get SAPB memory resource, 
HDCP not supported

The first one is an error print and the second is a warning. I think a 
dev_info about HDCP not supported would be enough.

  Tomi
Re: [PATCH v2] arm64: defconfig: Enable configs for DisplayPort on J721e
Posted by Rahul T R 4 years, 2 months ago
On 10:48-20220311, Tomi Valkeinen wrote:
> On 23/02/2022 12:15, Rahul T R wrote:
> > Enable DRM and PHY configs required for supporting
> > DisplayPort on J721e
> > 
> > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > ---
> > 
> > Notes:
> >      v2:
> >      	Fixed the places using savedefconfig
> >      	Added more info in notes
> >      No change in vmlinux:
> >      	add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
> >      	Function                                     old     new   delta
> >      	Total: Before=24042991, After=24042991, chg +0.00%
> >      Diffstat of bootlogs:
> >      	after_boot.log |   46 ++++++++++++++++++++++++++--------------------
> >      	1 file changed, 26 insertions(+), 20 deletions(-)
> > 
> >   arch/arm64/configs/defconfig | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 9f23d7ec1232..56d4c126f6da 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -736,6 +736,7 @@ CONFIG_DRM_THINE_THC63LVD1024=m
> >   CONFIG_DRM_TI_SN65DSI86=m
> >   CONFIG_DRM_I2C_ADV7511=m
> >   CONFIG_DRM_I2C_ADV7511_AUDIO=y
> > +CONFIG_DRM_CDNS_MHDP8546=m
> >   CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
> >   CONFIG_DRM_DW_HDMI_CEC=m
> >   CONFIG_DRM_IMX_DCSS=m
> > @@ -750,6 +751,7 @@ CONFIG_DRM_MESON=m
> >   CONFIG_DRM_PL111=m
> >   CONFIG_DRM_LIMA=m
> >   CONFIG_DRM_PANFROST=m
> > +CONFIG_DRM_TIDSS=m
> >   CONFIG_FB=y
> >   CONFIG_FB_MODE_HELPERS=y
> >   CONFIG_FB_EFI=y
> > @@ -1151,6 +1153,7 @@ CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> >   CONFIG_RESET_TI_SCI=y
> >   CONFIG_PHY_XGENE=y
> >   CONFIG_PHY_SUN4I_USB=y
> > +CONFIG_PHY_CADENCE_TORRENT=m
> >   CONFIG_PHY_MIXEL_MIPI_DPHY=m
> >   CONFIG_PHY_FSL_IMX8M_PCIE=y
> >   CONFIG_PHY_HI6220_USB=y
> > @@ -1175,6 +1178,7 @@ CONFIG_PHY_SAMSUNG_UFS=y
> >   CONFIG_PHY_UNIPHIER_USB2=y
> >   CONFIG_PHY_UNIPHIER_USB3=y
> >   CONFIG_PHY_TEGRA_XUSB=y
> > +CONFIG_PHY_J721E_WIZ=m
> >   CONFIG_ARM_SMMU_V3_PMU=m
> >   CONFIG_FSL_IMX8_DDR_PMU=m
> >   CONFIG_QCOM_L2_PMU=y
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> 
> Not directly related to this patch, but this is slightly annoying:
> 
> cdns-mhdp8546 a000000.dp-bridge: invalid resource
> cdns-mhdp8546 a000000.dp-bridge: Failed to get SAPB memory resource, HDCP
> not supported
> 
> The first one is an error print and the second is a warning. I think a
> dev_info about HDCP not supported would be enough.
> 
>  Tomi

Thanks Tomi,

Will discuss with cdns-mhdp driver maintainer and send a patch for this issue
Also will rebase and send a respin for this patch

Regards
Rahul T R