1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs

Aparna M posted 1 patch 4 years, 4 months ago
There is a newer version of this series
arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
[PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Posted by Aparna M 4 years, 4 months ago 
AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
gpio leds.

Signed-off-by: Aparna M <a-m1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index 6b04745147be..31e45bafa49e 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -8,6 +8,7 @@
 #include <dt-bindings/mux/ti-serdes.h>
 #include <dt-bindings/phy/phy.h>
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/net/ti-dp83867.h>
 #include "k3-am642.dtsi"
 
@@ -125,6 +126,67 @@
 		vin-supply = <&vcc_3v3_sys>;
 		gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led-0 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <1>;
+			gpios = <&exp2 0 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-1 {
+			color = <LED_COLOR_ID_RED>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <2>;
+			gpios = <&exp2 1 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-2 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <3>;
+			gpios = <&exp2 2 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-3 {
+			color = <LED_COLOR_ID_AMBER>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <4>;
+			gpios = <&exp2 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-4 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <5>;
+			gpios = <&exp2 4 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-5 {
+			color = <LED_COLOR_ID_RED>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <6>;
+			gpios = <&exp2 5 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-6 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <7>;
+			gpios = <&exp2 6 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+		led-7 {
+			color = <LED_COLOR_ID_AMBER>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <8>;
+			linux,default-trigger = "heartbeat";
+			gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
+		};
+	};
 };
 
 &main_pmx0 {
@@ -274,6 +336,14 @@
 				  "VPP_LDO_EN", "RPI_PS_3V3_En",
 				  "RPI_PS_5V0_En", "RPI_HAT_DETECT";
 	};
+
+	exp2: gpio@60 {
+		compatible = "ti,tpic2810";
+		reg = <0x60>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names = "LED1","LED2","LED3","LED4","LED5","LED6","LED7","LED8";
+	};
 };
 
 &main_i2c3 {
-- 
2.17.1
Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Posted by Nishanth Menon 4 years, 4 months ago 
On 14:02-20220223, Aparna M wrote:
> AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> gpio leds.
> 
> Signed-off-by: Aparna M <a-m1@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 6b04745147be..31e45bafa49e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
[...]

> +
> +	exp2: gpio@60 {
> +		compatible = "ti,tpic2810";

Sorry, but no.
please convert
	Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml

prior to any patches that enable it. (dtbs_check should have already
warned you about this).

> +		reg = <0x60>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		gpio-line-names = "LED1","LED2","LED3","LED4","LED5","LED6","LED7","LED8";
> +	};
>  };
>  
>  &main_i2c3 {
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Posted by Aparna M 4 years, 4 months ago 
On 07:55-20220223, Nishanth Menon wrote:
> On 14:02-20220223, Aparna M wrote:
> > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> > gpio leds.
> > 
> > Signed-off-by: Aparna M <a-m1@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > index 6b04745147be..31e45bafa49e 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> [...]
> 
> > +
> > +	exp2: gpio@60 {
> > +		compatible = "ti,tpic2810";
> 
> Sorry, but no.
> please convert
> 	Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml
> 
> prior to any patches that enable it. (dtbs_check should have already
> warned you about this).

A patch for changing binding to yaml has already been sent. 
Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/

> 
> > +		reg = <0x60>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +		gpio-line-names = "LED1","LED2","LED3","LED4","LED5","LED6","LED7","LED8";
> > +	};
> >  };
> >  
> >  &main_i2c3 {
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Thanks,
Aparna M
Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Posted by Nishanth Menon 4 years, 4 months ago 
On 21:48-20220223, Aparna M wrote:
> On 07:55-20220223, Nishanth Menon wrote:
> > On 14:02-20220223, Aparna M wrote:
> > > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> > > gpio leds.
> > > 
> > > Signed-off-by: Aparna M <a-m1@ti.com>
> > > ---
> > >  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> > >  1 file changed, 70 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > > index 6b04745147be..31e45bafa49e 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > [...]
> > 
> > > +
> > > +	exp2: gpio@60 {
> > > +		compatible = "ti,tpic2810";
> > 
> > Sorry, but no.
> > please convert
> > 	Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml
> > 
> > prior to any patches that enable it. (dtbs_check should have already
> > warned you about this).
> 
> A patch for changing binding to yaml has already been sent. 
> Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/

you have errors that you need to address. once the patch gets to
mainline master branch, then we can consider this patch.

Also in the future, when there is dependency such as these, you should
indicate that in the diffstat section rather than expecting maintainers
to go searching (we wont).

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.