[PATCH] ANDROID: dma-buf: system_heap: fix returnvar.cocci warnings

kernel test robot posted 1 patch 4 years, 4 months ago
drivers/dma-buf/heaps/system_heap.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] ANDROID: dma-buf: system_heap: fix returnvar.cocci warnings
Posted by kernel test robot 4 years, 4 months ago
From: kernel test robot <lkp@intel.com>

drivers/dma-buf/heaps/system_heap.c:312:5-8: Unneeded variable: "ret". Return "0" on line 321


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head:   0d36c5d6308623c56e2e94aff13e820cdd676bbf
commit: 44008f99d9ca0793e2562967e1da01fa74ee4a41 [4032/9999] ANDROID: dma-buf: system_heap: Add pagepool support to system heap
:::::: branch date: 6 hours ago
:::::: commit date: 1 year ago

 drivers/dma-buf/heaps/system_heap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/dma-buf/heaps/system_heap.c
+++ b/drivers/dma-buf/heaps/system_heap.c
@@ -309,7 +309,6 @@ static int system_heap_zero_buffer(struc
 	struct sg_page_iter piter;
 	struct page *p;
 	void *vaddr;
-	int ret = 0;
 
 	for_each_sgtable_page(sgt, &piter, 0) {
 		p = sg_page_iter_page(&piter);
@@ -318,7 +317,7 @@ static int system_heap_zero_buffer(struc
 		kunmap_atomic(vaddr);
 	}
 
-	return ret;
+	return 0;
 }
 
 static void system_heap_dma_buf_release(struct dma_buf *dmabuf)