[v1] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board

[PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board

Posted by Michael Walle 4 years, 4 months ago

Add a new compatible string for that eval board. It features an IMX8MN
UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 23e678232451..e11ffaa8721e 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -834,6 +834,7 @@ properties:
               - bsh,imx8mn-bsh-smm-s2     # i.MX8MN BSH SystemMaster S2
               - bsh,imx8mn-bsh-smm-s2pro  # i.MX8MN BSH SystemMaster S2 PRO
               - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
+              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
               - fsl,imx8mn-evk            # i.MX8MN LPDDR4 EVK Board
               - gw,imx8mn-gw7902          # i.MX8MM Gateworks Board
           - const: fsl,imx8mn
-- 
2.30.2

Re: [PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board

Posted by Krzysztof Kozlowski 4 years, 4 months ago

On 22/02/2022 16:13, Michael Walle wrote:
> Add a new compatible string for that eval board. It features an IMX8MN
> UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 23e678232451..e11ffaa8721e 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -834,6 +834,7 @@ properties:
>                - bsh,imx8mn-bsh-smm-s2     # i.MX8MN BSH SystemMaster S2
>                - bsh,imx8mn-bsh-smm-s2pro  # i.MX8MN BSH SystemMaster S2 PRO
>                - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
> +              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board

Looks good, just please put it in alphabetical order, so before ddr4,

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board

Posted by Michael Walle 4 years, 4 months ago

Am 2022-02-23 12:32, schrieb Krzysztof Kozlowski:
> On 22/02/2022 16:13, Michael Walle wrote:
>> Add a new compatible string for that eval board. It features an IMX8MN
>> UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.
>> 
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml 
>> b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 23e678232451..e11ffaa8721e 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -834,6 +834,7 @@ properties:
>>                - bsh,imx8mn-bsh-smm-s2     # i.MX8MN BSH SystemMaster 
>> S2
>>                - bsh,imx8mn-bsh-smm-s2pro  # i.MX8MN BSH SystemMaster 
>> S2 PRO
>>                - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
>> +              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
> 
> Looks good, just please put it in alphabetical order, so before ddr4,
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> 
> Best regards,
> Krzysztof

Thanks, I actually forgot to put Anson on CC as he has added the
other entries. Doing that now, also adding Peng Fan. Maybe they
have an opinion on the choosen name.

-michael

Re: [PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board

Posted by Heiko Thiery 4 years, 4 months ago

Hi,

Am Di., 22. Feb. 2022 um 16:14 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Add a new compatible string for that eval board. It features an IMX8MN
> UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.
>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 23e678232451..e11ffaa8721e 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -834,6 +834,7 @@ properties:
>                - bsh,imx8mn-bsh-smm-s2     # i.MX8MN BSH SystemMaster S2
>                - bsh,imx8mn-bsh-smm-s2pro  # i.MX8MN BSH SystemMaster S2 PRO
>                - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
> +              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
>                - fsl,imx8mn-evk            # i.MX8MN LPDDR4 EVK Board
>                - gw,imx8mn-gw7902          # i.MX8MM Gateworks Board
>            - const: fsl,imx8mn
> --
> 2.30.2
>