KVM:VMX:Remove scratch 'cpu' variable that shadows an identical scratch var

[PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an identical scratch var

Posted by Peng Hao 4 years, 4 months ago

 From: Peng Hao <flyingpeng@tencent.com> 

 Remove a redundant 'cpu' declaration from inside an if-statement that
 that shadows an identical declaration at function scope.  Both variables
 are used as scratch variables in for_each_*_cpu() loops, thus there's no
 harm in sharing a variable.

Reviewed-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
 arch/x86/kvm/vmx/vmx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index ba66c171d951..6101c2980a9c 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
 	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
 	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
 	    KVM_EVMCS_VERSION) {
-		int cpu;
 
 		/* Check that we have assist pages on all online CPUs */
 		for_each_online_cpu(cpu) {
-- 
2.27.0

Re: [PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an identical scratch var

Posted by Sean Christopherson 4 years, 4 months ago

Needs a space between "KVM:" and "VMX:".  No need to resend, Paolo can fixup when
applying.

On Tue, Feb 22, 2022, Peng Hao wrote:
>  From: Peng Hao <flyingpeng@tencent.com> 
> 
>  Remove a redundant 'cpu' declaration from inside an if-statement that
>  that shadows an identical declaration at function scope.  Both variables
>  are used as scratch variables in for_each_*_cpu() loops, thus there's no
>  harm in sharing a variable.
> 
> Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index ba66c171d951..6101c2980a9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
>  	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
>  	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
>  	    KVM_EVMCS_VERSION) {
> -		int cpu;
>  
>  		/* Check that we have assist pages on all online CPUs */
>  		for_each_online_cpu(cpu) {
> -- 
> 2.27.0
>

Re: [PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an identical scratch var

Posted by Paolo Bonzini 4 years, 4 months ago

On 2/22/22 11:39, Peng Hao wrote:
>   From: Peng Hao <flyingpeng@tencent.com>
> 
>   Remove a redundant 'cpu' declaration from inside an if-statement that
>   that shadows an identical declaration at function scope.  Both variables
>   are used as scratch variables in for_each_*_cpu() loops, thus there's no
>   harm in sharing a variable.
> 
> Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
>   arch/x86/kvm/vmx/vmx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index ba66c171d951..6101c2980a9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
>   	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
>   	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
>   	    KVM_EVMCS_VERSION) {
> -		int cpu;
>   
>   		/* Check that we have assist pages on all online CPUs */
>   		for_each_online_cpu(cpu) {

Queued, thanks.

Paolo