[PATCH] mips: setup: fix setnocoherentio() boolean setting

Randy Dunlap posted 1 patch 4 years, 4 months ago
arch/mips/kernel/setup.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] mips: setup: fix setnocoherentio() boolean setting
Posted by Randy Dunlap 4 years, 4 months ago
Correct a typo/pasto: setnocoherentio() should set
dma_default_coherent to false, not true.

Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
---
 arch/mips/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20220217.orig/arch/mips/kernel/setup.c
+++ linux-next-20220217/arch/mips/kernel/setup.c
@@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
 
 static int __init setnocoherentio(char *str)
 {
-	dma_default_coherent = true;
+	dma_default_coherent = false;
 	pr_info("Software DMA cache coherency (command line)\n");
 	return 0;
 }
Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting
Posted by Christoph Hellwig 4 years, 4 months ago
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting
Posted by Thomas Bogendoerfer 4 years, 4 months ago
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.
> 
> Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
>  arch/mips/kernel/setup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20220217.orig/arch/mips/kernel/setup.c
> +++ linux-next-20220217/arch/mips/kernel/setup.c
> @@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
>  
>  static int __init setnocoherentio(char *str)
>  {
> -	dma_default_coherent = true;
> +	dma_default_coherent = false;
>  	pr_info("Software DMA cache coherency (command line)\n");
>  	return 0;
>  }

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]