[PATCH -next] sched/fair: clean up some inconsistent indenting

Yang Li posted 1 patch 4 years, 4 months ago
There is a newer version of this series
kernel/sched/fair.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[PATCH -next] sched/fair: clean up some inconsistent indenting
Posted by Yang Li 4 years, 4 months ago
Eliminate the follow smatch warning:
kernel/sched/fair.c:5661 enqueue_task_fair() warn: inconsistent
indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 kernel/sched/fair.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 28b91f11b618..1ff3f45e24f3 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5654,12 +5654,12 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
 		if (cfs_rq_throttled(cfs_rq))
 			goto enqueue_throttle;
 
-               /*
-                * One parent has been throttled and cfs_rq removed from the
-                * list. Add it back to not break the leaf list.
-                */
-               if (throttled_hierarchy(cfs_rq))
-                       list_add_leaf_cfs_rq(cfs_rq);
+		/*
+		 * One parent has been throttled and cfs_rq removed from the
+		 * list. Add it back to not break the leaf list.
+		 */
+		if (throttled_hierarchy(cfs_rq))
+			list_add_leaf_cfs_rq(cfs_rq);
 	}
 
 	/* At this point se is NULL and we are at root level*/
-- 
2.20.1.7.g153144c

Re: [PATCH -next] sched/fair: clean up some inconsistent indenting
Posted by Mel Gorman 4 years, 4 months ago
On Thu, Feb 17, 2022 at 09:28:18AM +0800, Yang Li wrote:
> Eliminate the follow smatch warning:
> kernel/sched/fair.c:5661 enqueue_task_fair() warn: inconsistent
> indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

This is a whitespace fix that is more appropriate if modifying the actual
code and fixing the whitspace damage at the same time. Right now, it's
more useful for git blame to point to the commits that made meaningful
changes;

39f23ce07b93 ("sched/fair: Fix unthrottle_cfs_rq() for leaf_cfs_rq list")
304000390f88 ("sched: Cgroup SCHED_IDLE support")

-- 
Mel Gorman
SUSE Labs