[PATCH -next] HID: i2c-hid: remove unneeded semicolon

Yang Li posted 1 patch 4 years, 4 months ago
drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] HID: i2c-hid: remove unneeded semicolon
Posted by Yang Li 4 years, 4 months ago
Eliminate the following coccicheck warning:
./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 91b2fa0d33c7..c078f09a2318 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
 		 * With simple "send report" all data goes into the output
 		 * register.
 		 */
-		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
+		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
 		length += sizeof(__le16);
 	}
 
-- 
2.20.1.7.g153144c

Re: [PATCH -next] HID: i2c-hid: remove unneeded semicolon
Posted by Jiri Kosina 4 years, 4 months ago
On Wed, 16 Feb 2022, Yang Li wrote:

> Eliminate the following coccicheck warning:
> ./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 91b2fa0d33c7..c078f09a2318 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
>  		 * With simple "send report" all data goes into the output
>  		 * register.
>  		 */
> -		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
> +		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
>  		length += sizeof(__le16);
>  	}

Thanks, that was me fat-fingering the fixup in the original patch. 
Applied.

-- 
Jiri Kosina
SUSE Labs