[PATCH net-next] net: marvell: prestera: Fix includes

Yevhen Orlov posted 1 patch 4 years, 4 months ago
Failed in applying to current master (apply log)
drivers/net/ethernet/marvell/prestera/prestera_hw.h | 1 +
1 file changed, 1 insertion(+)
[PATCH net-next] net: marvell: prestera: Fix includes
Posted by Yevhen Orlov 4 years, 4 months ago
Include prestera.h in prestera_hw.h, because it may contain common
definitions.

Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
 drivers/net/ethernet/marvell/prestera/prestera_hw.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.h b/drivers/net/ethernet/marvell/prestera/prestera_hw.h
index 3ff12bae5909..24f2cf1c875f 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_hw.h
+++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.h
@@ -5,6 +5,7 @@
 #define _PRESTERA_HW_H_
 
 #include <linux/types.h>
+#include "prestera.h"
 #include "prestera_acl.h"
 
 enum prestera_accept_frm_type {
-- 
2.17.1

Re: [PATCH net-next] net: marvell: prestera: Fix includes
Posted by Jakub Kicinski 4 years, 4 months ago
On Mon, 14 Feb 2022 03:12:28 +0200 Yevhen Orlov wrote:
> Include prestera.h in prestera_hw.h, because it may contain common
> definitions.

*May*? Is prestera_hw.h using definitions from prestera.h today?
Dependencies between header files are best avoided completely.