[PATCH v2 00/10] random: re-group and re-document functions

Jason A. Donenfeld posted 10 patches 4 years, 4 months ago
drivers/char/random.c  | 1899 ++++++++++++++++++++--------------------
include/linux/random.h |    6 +-
2 files changed, 950 insertions(+), 955 deletions(-)
[PATCH v2 00/10] random: re-group and re-document functions
Posted by Jason A. Donenfeld 4 years, 4 months ago
We previously had massive documentation comments and functions strewn
all about. This attempts to restore sanity by dividing the code into a
few sections:

- Initialization and readiness waiting.
- Fast key erasure RNG.
- Entropy accumulation and extraction.
- Entropy collection.
- Userspace read/write.
- Sysctl.

The result of this ordering and this grouping is only 2 forward
declarations, indicating that this is probably a sensible grouping.
Also, some documentation that was just hopelessly out of date been
removed. We'll later look into re-adding parts of this to the Linux man
pages project.

No functional changes.

Jason A. Donenfeld (10):
  random: introduce drain_entropy() helper to declutter crng_reseed()
  random: remove useless header comment
  random: remove whitespace and reorder includes
  random: group initialization wait functions
  random: group crng functions
  random: group entropy extraction functions
  random: group entropy collection functions
  random: group userspace read/write functions
  random: group sysctl functions
  random: rewrite header introductory comment

 drivers/char/random.c  | 1899 ++++++++++++++++++++--------------------
 include/linux/random.h |    6 +-
 2 files changed, 950 insertions(+), 955 deletions(-)

-- 
2.35.0

Re: [PATCH v2 00/10] random: re-group and re-document functions
Posted by Dominik Brodowski 4 years, 4 months ago
Am Sat, Feb 12, 2022 at 01:23:08PM +0100 schrieb Jason A. Donenfeld:
> We previously had massive documentation comments and functions strewn
> all about. This attempts to restore sanity by dividing the code into a
> few sections:
> 
> - Initialization and readiness waiting.
> - Fast key erasure RNG.
> - Entropy accumulation and extraction.
> - Entropy collection.
> - Userspace read/write.
> - Sysctl.
> 
> The result of this ordering and this grouping is only 2 forward
> declarations, indicating that this is probably a sensible grouping.
> Also, some documentation that was just hopelessly out of date been
> removed. We'll later look into re-adding parts of this to the Linux man
> pages project.
> 
> No functional changes.

Hi Jason,

thanks for your massive patchset. While some of it was a bit tedious and
repetetive to review, feel free to add my

	Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>

to patchs 1-3, 6 and 8-10. For patches 4, 5 and 7, I have some comments;
once addressed, feel free to add my reviewed-by tag to those as well.

Thanks,
	Dominik
Re: [PATCH v2 00/10] random: re-group and re-document functions
Posted by Jason A. Donenfeld 4 years, 4 months ago
On Sun, Feb 13, 2022 at 7:57 AM Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
>
> thanks for your massive patchset. While some of it was a bit tedious and
> repetetive to review, feel free to add my

Thank you very much for slogging through it and reviewing it! Much appreciated.