[PATCH] net: fix documentation for kernel_getsockname

Alex Maydanik posted 1 patch 4 years, 4 months ago
net/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] net: fix documentation for kernel_getsockname
Posted by Alex Maydanik 4 years, 4 months ago
Fixes return value documentation of kernel_getsockname()
and kernel_getpeername() functions.

The previous documentation wrongly specified that the return
value is 0 in case of success, however sock->ops->getname returns
the length of the address in bytes in case of success.

Signed-off-by: Alex Maydanik <alexander.maydanik@gmail.com>
---
 net/socket.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index 50cf75730fd7..982eecad464c 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -3448,7 +3448,7 @@ EXPORT_SYMBOL(kernel_connect);
  *	@addr: address holder
  *
  * 	Fills the @addr pointer with the address which the socket is bound.
- *	Returns 0 or an error code.
+ *	Returns the length of the address in bytes or an error code.
  */
 
 int kernel_getsockname(struct socket *sock, struct sockaddr *addr)
@@ -3463,7 +3463,7 @@ EXPORT_SYMBOL(kernel_getsockname);
  *	@addr: address holder
  *
  * 	Fills the @addr pointer with the address which the socket is connected.
- *	Returns 0 or an error code.
+ *	Returns the length of the address in bytes or an error code.
  */
 
 int kernel_getpeername(struct socket *sock, struct sockaddr *addr)
-- 
2.25.1

Re: [PATCH] net: fix documentation for kernel_getsockname
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 4 months ago
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Sat, 12 Feb 2022 12:29:27 +0200 you wrote:
> Fixes return value documentation of kernel_getsockname()
> and kernel_getpeername() functions.
> 
> The previous documentation wrongly specified that the return
> value is 0 in case of success, however sock->ops->getname returns
> the length of the address in bytes in case of success.
> 
> [...]

Here is the summary with links:
  - net: fix documentation for kernel_getsockname
    https://git.kernel.org/netdev/net/c/0fc95dec096c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html