exec: cleanup comments

[PATCH] exec: cleanup comments

Posted by trix@redhat.com 4 years, 4 months ago

From: Tom Rix <trix@redhat.com>

Remove the second 'from'.
Replace 'backwords' with 'backwards'.
Replace 'visibile' with 'visible'.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 fs/exec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index 40b1008fb0f7..8256e8bb9ad3 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
  * Note that a shared library must be both readable and executable due to
  * security reasons.
  *
- * Also note that we take the address to load from from the file itself.
+ * Also note that we take the address to load from the file itself.
  */
 SYSCALL_DEFINE1(uselib, const char __user *, library)
 {
@@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
 		if (!valid_arg_len(bprm, len))
 			goto out;
 
-		/* We're going to work our way backwords. */
+		/* We're going to work our way backwards. */
 		pos = bprm->p;
 		str += len;
 		bprm->p -= len;
@@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
 
 	/*
 	 * Must be called _before_ exec_mmap() as bprm->mm is
-	 * not visibile until then. This also enables the update
+	 * not visible until then. This also enables the update
 	 * to be lockless.
 	 */
 	retval = set_mm_exe_file(bprm->mm, bprm->file);
-- 
2.26.3

Re: [PATCH] exec: cleanup comments

Posted by Randy Dunlap 4 years, 4 months ago


On 2/11/22 08:09, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/exec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 40b1008fb0f7..8256e8bb9ad3 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
>   * Note that a shared library must be both readable and executable due to
>   * security reasons.
>   *
> - * Also note that we take the address to load from from the file itself.
> + * Also note that we take the address to load from the file itself.
>   */
>  SYSCALL_DEFINE1(uselib, const char __user *, library)
>  {
> @@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>  		if (!valid_arg_len(bprm, len))
>  			goto out;
>  
> -		/* We're going to work our way backwords. */
> +		/* We're going to work our way backwards. */
>  		pos = bprm->p;
>  		str += len;
>  		bprm->p -= len;
> @@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
>  
>  	/*
>  	 * Must be called _before_ exec_mmap() as bprm->mm is
> -	 * not visibile until then. This also enables the update
> +	 * not visible until then. This also enables the update
>  	 * to be lockless.
>  	 */
>  	retval = set_mm_exe_file(bprm->mm, bprm->file);

-- 
~Randy

Re: [PATCH] exec: cleanup comments

Posted by Kees Cook 4 years, 4 months ago

On Fri, 11 Feb 2022 08:09:40 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
> 
> 
> [...]

Applied to for-next/execve, thanks!

[1/1] exec: cleanup comments
      https://git.kernel.org/kees/c/92eec5b2f7b8

-- 
Kees Cook