[v1] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

[PATCH] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

Posted by Rahul T R 4 years, 4 months ago

Initialize bpc while creating panel_desc structure for RK101II01D-CT

Below warning is triggered since bpc is not being initialized

WARNING: CPU: 2 PID: 47 at drivers/gpu/drm/panel/panel-simple.c:614
panel_simple_probe+0x1b0/0x3c8

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index c324a3ed34b9..c09eb5ad65fc 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3058,6 +3058,7 @@ static const struct drm_display_mode rocktech_rk101ii01d_ct_mode = {
 
 static const struct panel_desc rocktech_rk101ii01d_ct = {
 	.modes = &rocktech_rk101ii01d_ct_mode,
+	.bpc = 8,
 	.num_modes = 1,
 	.size = {
 		.width = 217,
-- 
2.17.1

Re: [PATCH] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

Posted by Tomi Valkeinen 4 years, 4 months ago

On 10/02/2022 16:03, Rahul T R wrote:
> Initialize bpc while creating panel_desc structure for RK101II01D-CT
> 
> Below warning is triggered since bpc is not being initialized
> 
> WARNING: CPU: 2 PID: 47 at drivers/gpu/drm/panel/panel-simple.c:614
> panel_simple_probe+0x1b0/0x3c8
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index c324a3ed34b9..c09eb5ad65fc 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3058,6 +3058,7 @@ static const struct drm_display_mode rocktech_rk101ii01d_ct_mode = {
>   
>   static const struct panel_desc rocktech_rk101ii01d_ct = {
>   	.modes = &rocktech_rk101ii01d_ct_mode,
> +	.bpc = 8,
>   	.num_modes = 1,
>   	.size = {
>   		.width = 217,

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi

Re: [PATCH] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

Posted by Tomi Valkeinen 4 years, 3 months ago

On 10/02/2022 16:03, Rahul T R wrote:
> Initialize bpc while creating panel_desc structure for RK101II01D-CT
> 
> Below warning is triggered since bpc is not being initialized
> 
> WARNING: CPU: 2 PID: 47 at drivers/gpu/drm/panel/panel-simple.c:614
> panel_simple_probe+0x1b0/0x3c8
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index c324a3ed34b9..c09eb5ad65fc 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3058,6 +3058,7 @@ static const struct drm_display_mode rocktech_rk101ii01d_ct_mode = {
>   
>   static const struct panel_desc rocktech_rk101ii01d_ct = {
>   	.modes = &rocktech_rk101ii01d_ct_mode,
> +	.bpc = 8,
>   	.num_modes = 1,
>   	.size = {
>   		.width = 217,

Thanks, looks good to me. I'll apply to drm-misc-next.

  Tomi