[v1] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

[PATCH] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

Posted by Leonardo Araujo 4 years, 4 months ago

This patch fixes the following checkpatch.pl warning:

WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Leonardo Araujo <leonardo.aa88@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index c7e8602d2097..a9a5453aa1cc 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -188,7 +188,7 @@ u32 rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
 	cmd_obj->padapter = padapter;
 
 	res = rtw_cmd_filter(pcmdpriv, cmd_obj);
-	if (_FAIL == res) {
+	if (res == _FAIL) {
 		rtw_free_cmd_obj(cmd_obj);
 		goto exit;
 	}
-- 
2.29.0

Re: [PATCH] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

Posted by Greg KH 4 years, 4 months ago

On Wed, Feb 09, 2022 at 05:20:15PM -0300, Leonardo Araujo wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Comparisons should place the constant on the right side of the test
> 
> Signed-off-by: Leonardo Araujo <leonardo.aa88@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Also you need to properly cc: the relevant maintainers, as
get_maintainer.pl will show you.

I have dropped all of your pending patches from my queue.  Please fix
them up and send a patch series.

thanks,

greg k-h