[PATCH] io_uring: Fix uninitialized use of ret in io_eventfd_register()

Jiapeng Chong posted 1 patch 4 years, 4 months ago
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] io_uring: Fix uninitialized use of ret in io_eventfd_register()
Posted by Jiapeng Chong 4 years, 4 months ago
In some scenarios, ret is not assigned in the whole process, so it
needs to be initialized at the beginning.

Clean up the following clang warning:

fs/io_uring.c:9373:13: note: initialize the variable 'ret' to silence
this warning.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 5479f0607430..7f277890f1ec 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -9370,7 +9370,7 @@ static int io_eventfd_register(struct io_ring_ctx *ctx, void __user *arg,
 {
 	struct io_ev_fd *ev_fd;
 	__s32 __user *fds = arg;
-	int fd, ret;
+	int fd, ret = 0;
 
 	ev_fd = rcu_dereference_protected(ctx->io_ev_fd,
 					lockdep_is_held(&ctx->uring_lock));
-- 
2.20.1.7.g153144c

Re: [PATCH] io_uring: Fix uninitialized use of ret in io_eventfd_register()
Posted by Ammar Faizi 4 years, 4 months ago
On 2/9/22 5:26 PM, Jiapeng Chong wrote:
> In some scenarios, ret is not assigned in the whole process, so it
> needs to be initialized at the beginning.
> 
> Clean up the following clang warning:
> 
> fs/io_uring.c:9373:13: note: initialize the variable 'ret' to silence
> this warning.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---

This is already fixed in commit
4c65723081332607ca331072b0f8a90189e2e447 ("io_uring: Fix use of uninitialized ret in io_eventfd_register()")

https://lore.kernel.org/all/20220207162410.1013466-1-nathan@kernel.org/T/

https://github.com/torvalds/linux/commit/4c65723081332607ca331072b0f8a90189e2e447.patch

-- 
Ammar Faizi