tick: Fix softirq related warnings

[PATCH 0/3] tick: Fix softirq related warnings

Posted by Frederic Weisbecker 4 years, 4 months ago

Some cleanups and debug rework.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
	timers/core

HEAD: 18b00369d58da4c73946d5f8ebed8e8c7ade89e2

Thanks,
	Frederic
---

Frederic Weisbecker (3):
      tick/rcu: Remove obsolete rcu_needs_cpu() parameters
      tick/rcu: Stop allowing RCU_SOFTIRQ in idle
      lib/irq_poll: Declare IRQ_POLL softirq vector as ksoftirqd-parking safe


 include/linux/interrupt.h | 11 ++++++++-
 include/linux/rcutiny.h   |  3 +--
 include/linux/rcutree.h   |  2 +-
 kernel/rcu/tree.c         |  3 +--
 kernel/time/tick-sched.c  | 60 ++++++++++++++++++++++++++++++++++-------------
 5 files changed, 57 insertions(+), 22 deletions(-)

Re: [PATCH 0/3] tick: Fix softirq related warnings

Posted by Paul E. McKenney 4 years, 4 months ago

On Tue, Feb 08, 2022 at 05:16:32PM +0100, Frederic Weisbecker wrote:
> Some cleanups and debug rework.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	timers/core
> 
> HEAD: 18b00369d58da4c73946d5f8ebed8e8c7ade89e2
> 
> Thanks,
> 	Frederic
> ---
> 
> Frederic Weisbecker (3):
>       tick/rcu: Remove obsolete rcu_needs_cpu() parameters
>       tick/rcu: Stop allowing RCU_SOFTIRQ in idle
>       lib/irq_poll: Declare IRQ_POLL softirq vector as ksoftirqd-parking safe

I have queued these for local testing, but I am guessing that you would
like them to go up some other path.

							Thanx, Paul

>  include/linux/interrupt.h | 11 ++++++++-
>  include/linux/rcutiny.h   |  3 +--
>  include/linux/rcutree.h   |  2 +-
>  kernel/rcu/tree.c         |  3 +--
>  kernel/time/tick-sched.c  | 60 ++++++++++++++++++++++++++++++++++-------------
>  5 files changed, 57 insertions(+), 22 deletions(-)

Re: [PATCH 0/3] tick: Fix softirq related warnings

Posted by Paul Menzel 4 years, 4 months ago

Dear Frederic,


Am 08.02.22 um 17:16 schrieb Frederic Weisbecker:
> Some cleanups and debug rework.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	timers/core
> 
> HEAD: 18b00369d58da4c73946d5f8ebed8e8c7ade89e2
> 
> Thanks,
> 	Frederic
> ---
> 
> Frederic Weisbecker (3):
>        tick/rcu: Remove obsolete rcu_needs_cpu() parameters
>        tick/rcu: Stop allowing RCU_SOFTIRQ in idle
>        lib/irq_poll: Declare IRQ_POLL softirq vector as ksoftirqd-parking safe
> 
> 
>   include/linux/interrupt.h | 11 ++++++++-
>   include/linux/rcutiny.h   |  3 +--
>   include/linux/rcutree.h   |  2 +-
>   kernel/rcu/tree.c         |  3 +--
>   kernel/time/tick-sched.c  | 60 ++++++++++++++++++++++++++++++++++-------------
>   5 files changed, 57 insertions(+), 22 deletions(-)

I tested this series on the IBM S822LC with Ubuntu 20.10 and rcu/dev 
(commit 0ba8896d2fd7 (lib/irq_poll: Declare IRQ_POLL softirq vector as 
ksoftirqd-parking safe)). Running `sudo ppc64_cpu --smt=off` the 
warnings are gone.

Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH 0/3] tick: Fix softirq related warnings

Posted by Paul E. McKenney 4 years, 4 months ago

On Mon, Feb 14, 2022 at 06:46:59AM +0100, Paul Menzel wrote:
> Dear Frederic,
> 
> 
> Am 08.02.22 um 17:16 schrieb Frederic Weisbecker:
> > Some cleanups and debug rework.
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> > 	timers/core
> > 
> > HEAD: 18b00369d58da4c73946d5f8ebed8e8c7ade89e2
> > 
> > Thanks,
> > 	Frederic
> > ---
> > 
> > Frederic Weisbecker (3):
> >        tick/rcu: Remove obsolete rcu_needs_cpu() parameters
> >        tick/rcu: Stop allowing RCU_SOFTIRQ in idle
> >        lib/irq_poll: Declare IRQ_POLL softirq vector as ksoftirqd-parking safe
> > 
> > 
> >   include/linux/interrupt.h | 11 ++++++++-
> >   include/linux/rcutiny.h   |  3 +--
> >   include/linux/rcutree.h   |  2 +-
> >   kernel/rcu/tree.c         |  3 +--
> >   kernel/time/tick-sched.c  | 60 ++++++++++++++++++++++++++++++++++-------------
> >   5 files changed, 57 insertions(+), 22 deletions(-)
> 
> I tested this series on the IBM S822LC with Ubuntu 20.10 and rcu/dev (commit
> 0ba8896d2fd7 (lib/irq_poll: Declare IRQ_POLL softirq vector as
> ksoftirqd-parking safe)). Running `sudo ppc64_cpu --smt=off` the warnings
> are gone.
> 
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>

I will apply on my next rebase, thank you!

And thanks to Peter and Christophe for chasing this down!

							Thanx, Paul