ext2: remove unused pointer bdi

[PATCH][next] ext2: remove unused pointer bdi

Posted by Colin Ian King 4 years, 4 months ago

The call to bdi_congested has been removed and so the bdi pointer
is no longer required. Remove it.

Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/ext2/ialloc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index d632764da240..998dd2ac8008 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
 	unsigned long offset;
 	unsigned long block;
 	struct ext2_group_desc * gdp;
-	struct backing_dev_info *bdi;
-
-	bdi = inode_to_bdi(inode);
 
 	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
 	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
-- 
2.34.1

Re: [PATCH][next] ext2: remove unused pointer bdi

Posted by Jan Kara 4 years, 4 months ago

On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> The call to bdi_congested has been removed and so the bdi pointer
> is no longer required. Remove it.
> 
> Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

I guess this change is in mm tree? So probably it is best if Andrew picks
it up.

								Honza

> ---
>  fs/ext2/ialloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index d632764da240..998dd2ac8008 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
>  	unsigned long offset;
>  	unsigned long block;
>  	struct ext2_group_desc * gdp;
> -	struct backing_dev_info *bdi;
> -
> -	bdi = inode_to_bdi(inode);
>  
>  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
>  	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH][next] ext2: remove unused pointer bdi

Posted by NeilBrown 4 years, 4 months ago

On Tue, 08 Feb 2022, Jan Kara wrote:
> On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> > The call to bdi_congested has been removed and so the bdi pointer
> > is no longer required. Remove it.
> > 
> > Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> I guess this change is in mm tree? So probably it is best if Andrew picks
> it up.

I have to refresh the whole series - hopefully later this week.  I'll
make sure to fix this bit.

Thanks,
NeilBrown


> 
> 								Honza
> 
> > ---
> >  fs/ext2/ialloc.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> > index d632764da240..998dd2ac8008 100644
> > --- a/fs/ext2/ialloc.c
> > +++ b/fs/ext2/ialloc.c
> > @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
> >  	unsigned long offset;
> >  	unsigned long block;
> >  	struct ext2_group_desc * gdp;
> > -	struct backing_dev_info *bdi;
> > -
> > -	bdi = inode_to_bdi(inode);
> >  
> >  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> >  	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> > -- 
> > 2.34.1
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
> 
>