[PATCH] pinctrl: starfive: fix semicolon.cocci warnings

kernel test robot posted 1 patch 4 years, 4 months ago
pinctrl-starfive.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] pinctrl: starfive: fix semicolon.cocci warnings
Posted by kernel test robot 4 years, 4 months ago
From: kernel test robot <lkp@intel.com>

drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago

 pinctrl-starfive.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/pinctrl/pinctrl-starfive.c
+++ b/drivers/pinctrl/pinctrl-starfive.c
@@ -1026,7 +1026,7 @@ static int starfive_gpio_set_config(stru
 		break;
 	default:
 		return -ENOTSUPP;
-	};
+	}
 
 	starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio), mask, value);
 	return 0;
Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings
Posted by Emil Renner Berthing 4 years, 4 months ago
On Sun, 6 Feb 2022 at 01:38, kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks. There is already a previous patch for this although it was
sent before this code was in Linus' tree:
https://lore.kernel.org/all/20211222073522.123656-1-yang.lee@linux.alibaba.com/

/Emil
Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings
Posted by Linus Walleij 4 years, 4 months ago
On Sun, Feb 6, 2022 at 1:37 AM kernel test robot <lkp@intel.com> wrote:

> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Applied this patch and added the alibaba reporters as
Reported-by.

Yours,
Linus Walleij