[PATCH] pinctrl: samsung: improve wake irq info on console

Martin Jücker posted 1 patch 4 years, 5 months ago
drivers/pinctrl/samsung/pinctrl-exynos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] pinctrl: samsung: improve wake irq info on console
Posted by Martin Jücker 4 years, 5 months ago
Improve the wake irq message by also printing the bank name and hwirq
number that matches this irq number.

Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 0489c899b401..30293fc23354 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -344,7 +344,8 @@ static int exynos_wkup_irq_set_wake(struct irq_data *irqd, unsigned int on)
 	struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd);
 	unsigned long bit = 1UL << (2 * bank->eint_offset + irqd->hwirq);
 
-	pr_info("wake %s for irq %d\n", on ? "enabled" : "disabled", irqd->irq);
+	pr_info("wake %s for irq %u (%s-%lu)\n", on ? "enabled" : "disabled",
+		irqd->irq, bank->name, irqd->hwirq);
 
 	if (!on)
 		*our_chip->eint_wake_mask_value |= bit;
-- 
2.25.1

Re: [PATCH] pinctrl: samsung: improve wake irq info on console
Posted by Krzysztof Kozlowski 4 years, 4 months ago
On Mon, 31 Jan 2022 00:21:22 +0100, Martin Jücker wrote:
> Improve the wake irq message by also printing the bank name and hwirq
> number that matches this irq number.
> 
> 

Applied, thanks!

[1/1] pinctrl: samsung: improve wake irq info on console
      commit: 3652dc070bad335d6feb31402bb4ab1ad58d5cb6

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Re: [PATCH] pinctrl: samsung: improve wake irq info on console
Posted by Andy Shevchenko 4 years, 4 months ago
On Tue, Feb 1, 2022 at 5:11 PM Martin Jücker <martin.juecker@gmail.com> wrote:
>
> Improve the wake irq message by also printing the bank name and hwirq
> number that matches this irq number.

Perhaps wait a bit and replace the first argument with str_enabled_disabled()?

-- 
With Best Regards,
Andy Shevchenko