arm64: dts: juno: align pl330 node name with dtschema

[PATCH] arm64: dts: juno: align pl330 node name with dtschema

Posted by Krzysztof Kozlowski 4 years, 5 months ago

Fixes dtbs_check warning:

  dma@7ff00000: $nodename:0: 'dma@7ff00000' does not match '^dma-controller(@.*)?$'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 6288e104a089..af499049cb00 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -672,7 +672,7 @@ smmu_usb: iommu@7fb30000 {
 		dma-coherent;
 	};
 
-	dma@7ff00000 {
+	dma-controller@7ff00000 {
 		compatible = "arm,pl330", "arm,primecell";
 		reg = <0x0 0x7ff00000 0 0x1000>;
 		#dma-cells = <1>;
-- 
2.32.0

Re: [PATCH] arm64: dts: juno: align pl330 node name with dtschema

Posted by Sudeep Holla 4 years, 3 months ago

On Sat, Jan 29, 2022 at 06:56:21PM +0100, Krzysztof Kozlowski wrote:
> Fixes dtbs_check warning:
> 
>   dma@7ff00000: $nodename:0: 'dma@7ff00000' does not match '^dma-controller(@.*)?$'
>

Sorry for the delay, obviously I missed this. Looks fine for me.
I see you have already sent pull request which is good as I don't
have any other juno DTS patch at the moment.

Just in case it helps SoC team to pull you PR,

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

--
Regards,
Sudeep

Re: [PATCH] arm64: dts: juno: align pl330 node name with dtschema

Posted by Krzysztof Kozlowski 4 years, 3 months ago

On 07/03/2022 19:29, Sudeep Holla wrote:
> On Sat, Jan 29, 2022 at 06:56:21PM +0100, Krzysztof Kozlowski wrote:
>> Fixes dtbs_check warning:
>>
>>   dma@7ff00000: $nodename:0: 'dma@7ff00000' does not match '^dma-controller(@.*)?$'
>>
> 
> Sorry for the delay, obviously I missed this. Looks fine for me.
> I see you have already sent pull request which is good as I don't
> have any other juno DTS patch at the moment.
> 
> Just in case it helps SoC team to pull you PR,
> 
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> 

Thanks!


Best regards,
Krzysztof