[PATCH] soundwire: intel: fix wrong register name in intel_shim_wake

Bard Liao posted 1 patch 4 years, 5 months ago
drivers/soundwire/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] soundwire: intel: fix wrong register name in intel_shim_wake
Posted by Bard Liao 4 years, 5 months ago
From: Libin Yang <libin.yang@intel.com>

When clearing the sdw wakests status, we should use SDW_SHIM_WAKESTS.

Fixes: 4a17c441c7cb ("soundwire: intel: revisit SHIM programming sequences.")
Signed-off-by: Libin Yang <libin.yang@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 drivers/soundwire/intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 122f7a29d8ca..63101f1ba271 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -448,8 +448,8 @@ static void intel_shim_wake(struct sdw_intel *sdw, bool wake_enable)
 
 		/* Clear wake status */
 		wake_sts = intel_readw(shim, SDW_SHIM_WAKESTS);
-		wake_sts |= (SDW_SHIM_WAKEEN_ENABLE << link_id);
-		intel_writew(shim, SDW_SHIM_WAKESTS_STATUS, wake_sts);
+		wake_sts |= (SDW_SHIM_WAKESTS_STATUS << link_id);
+		intel_writew(shim, SDW_SHIM_WAKESTS, wake_sts);
 	}
 	mutex_unlock(sdw->link_res->shim_lock);
 }
-- 
2.17.1

Re: [PATCH] soundwire: intel: fix wrong register name in intel_shim_wake
Posted by Vinod Koul 4 years, 4 months ago
On 26-01-22, 09:14, Bard Liao wrote:
> From: Libin Yang <libin.yang@intel.com>
> 
> When clearing the sdw wakests status, we should use SDW_SHIM_WAKESTS.

Applied, thanks

-- 
~Vinod