[PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"

Colin Ian King posted 1 patch 4 years, 5 months ago
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"
Posted by Colin Ian King 4 years, 5 months ago
There is a spelling mistake in a drm_err error message. Fix it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 1331ff91c5b0..1ae3d1f259e3 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -3942,7 +3942,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 		guc_context_replay(ce);
 	} else {
 		drm_err(&guc_to_gt(guc)->i915->drm,
-			"Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d",
+			"Invalid GuC engine reset notification for 0x%04X on %s: banned = %d, blocked = %d",
 			ce->guc_id.id, ce->engine->name, intel_context_is_banned(ce),
 			context_blocked(ce));
 	}
-- 
2.33.1

Re: [PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"
Posted by John Harrison 4 years, 5 months ago
On 1/25/2022 01:13, Colin Ian King wrote:
> There is a spelling mistake in a drm_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

However, note that this message is going to be deleted anyway. Or at 
least dropped down to an informational. Partly, there was confusion over 
how the issue could arise. Partly the firmware bug leading to part of 
the problem has now been fixed and the w/a removed from the driver. 
Cleaning this error up accordingly is on my todo list...

Thanks,
John.


> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 1331ff91c5b0..1ae3d1f259e3 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -3942,7 +3942,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
>   		guc_context_replay(ce);
>   	} else {
>   		drm_err(&guc_to_gt(guc)->i915->drm,
> -			"Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d",
> +			"Invalid GuC engine reset notification for 0x%04X on %s: banned = %d, blocked = %d",
>   			ce->guc_id.id, ce->engine->name, intel_context_is_banned(ce),
>   			context_blocked(ce));
>   	}