[PATCH 00/10] Cleanup and removal of DBG_88E macro

Phillip Potter posted 10 patches 4 years, 5 months ago
drivers/staging/r8188eu/Makefile              |   1 -
drivers/staging/r8188eu/core/rtw_ap.c         | 108 +----
drivers/staging/r8188eu/core/rtw_br_ext.c     |  59 +--
drivers/staging/r8188eu/core/rtw_cmd.c        |  12 +-
drivers/staging/r8188eu/core/rtw_ieee80211.c  |  37 +-
drivers/staging/r8188eu/core/rtw_ioctl_set.c  |  15 +-
drivers/staging/r8188eu/core/rtw_iol.c        |  10 +-
drivers/staging/r8188eu/core/rtw_mlme.c       |  54 +--
drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 343 +--------------
drivers/staging/r8188eu/core/rtw_p2p.c        |  61 +--
drivers/staging/r8188eu/core/rtw_pwrctrl.c    |  49 +--
drivers/staging/r8188eu/core/rtw_recv.c       |  73 +--
drivers/staging/r8188eu/core/rtw_security.c   |  19 +-
drivers/staging/r8188eu/core/rtw_sta_mgt.c    |   6 -
drivers/staging/r8188eu/core/rtw_wlan_util.c  | 102 +----
drivers/staging/r8188eu/core/rtw_xmit.c       |  62 +--
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c    |   4 +-
drivers/staging/r8188eu/hal/hal_intf.c        |   3 -
drivers/staging/r8188eu/hal/odm_debug.c       |   6 -
drivers/staging/r8188eu/hal/rtl8188e_cmd.c    |  43 +-
.../staging/r8188eu/hal/rtl8188e_hal_init.c   |  95 +---
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c |   3 -
drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |   5 -
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |   8 +-
drivers/staging/r8188eu/hal/usb_halinit.c     |  62 +--
drivers/staging/r8188eu/hal/usb_ops_linux.c   |  31 +-
drivers/staging/r8188eu/include/rtw_br_ext.h  |   5 -
drivers/staging/r8188eu/include/rtw_debug.h   |   8 -
drivers/staging/r8188eu/include/usb_ops.h     |   5 +-
drivers/staging/r8188eu/os_dep/ioctl_linux.c  | 416 +-----------------
drivers/staging/r8188eu/os_dep/mlme_linux.c   |   4 -
drivers/staging/r8188eu/os_dep/os_intfs.c     |  34 +-
.../staging/r8188eu/os_dep/osdep_service.c    |   2 -
drivers/staging/r8188eu/os_dep/usb_intf.c     |  84 +---
.../staging/r8188eu/os_dep/usb_ops_linux.c    |  18 +-
drivers/staging/r8188eu/os_dep/xmit_linux.c   |   6 +-
36 files changed, 166 insertions(+), 1687 deletions(-)
delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c
[PATCH 00/10] Cleanup and removal of DBG_88E macro
Posted by Phillip Potter 4 years, 5 months ago
This series does a few things in order to effect the removal of the
DBG_88E macro:

(1) It removes previously converted calls for consistency.
(2) It removes all current DBG_88E calls.
(3) It removes all aliased DBG_88E calls.
(4) It removes the GlobalDebugLevel flag and the file that defines it.

By its very nature, it is a large patchset, so I've tried to group as
appropriate. I went by file as I did the work, which led to over 40
patches originally, so I've listed the largest C files as their own
patches and then grouped everything else by subdir which gives closer
sizes for the other patches.

Phillip Potter (10):
  staging: r8188eu: remove previously added dev_dbg and netdev_dbg calls
  staging: r8188eu: remove smaller sets of DBG_88E calls from core dir
  staging: r8188eu: remove DBG_88E calls from core/rtw_mlme_ext.c
  staging: r8188eu: remove all DBG_88E calls from hal dir
  staging: r8188eu: remove smaller sets of DBG_88E calls from os_dep dir
  staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c
  staging: r8188eu: remove DBG_88E call from include/usb_ops.h
  staging: r8188eu: remove all remaining aliased DBG_88E calls
  staging: r8188eu: remove DBG_88E macro definition
  staging: r8188eu: remove GlobalDebugLevel flag

 drivers/staging/r8188eu/Makefile              |   1 -
 drivers/staging/r8188eu/core/rtw_ap.c         | 108 +----
 drivers/staging/r8188eu/core/rtw_br_ext.c     |  59 +--
 drivers/staging/r8188eu/core/rtw_cmd.c        |  12 +-
 drivers/staging/r8188eu/core/rtw_ieee80211.c  |  37 +-
 drivers/staging/r8188eu/core/rtw_ioctl_set.c  |  15 +-
 drivers/staging/r8188eu/core/rtw_iol.c        |  10 +-
 drivers/staging/r8188eu/core/rtw_mlme.c       |  54 +--
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 343 +--------------
 drivers/staging/r8188eu/core/rtw_p2p.c        |  61 +--
 drivers/staging/r8188eu/core/rtw_pwrctrl.c    |  49 +--
 drivers/staging/r8188eu/core/rtw_recv.c       |  73 +--
 drivers/staging/r8188eu/core/rtw_security.c   |  19 +-
 drivers/staging/r8188eu/core/rtw_sta_mgt.c    |   6 -
 drivers/staging/r8188eu/core/rtw_wlan_util.c  | 102 +----
 drivers/staging/r8188eu/core/rtw_xmit.c       |  62 +--
 drivers/staging/r8188eu/hal/HalPwrSeqCmd.c    |   4 +-
 drivers/staging/r8188eu/hal/hal_intf.c        |   3 -
 drivers/staging/r8188eu/hal/odm_debug.c       |   6 -
 drivers/staging/r8188eu/hal/rtl8188e_cmd.c    |  43 +-
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  95 +---
 drivers/staging/r8188eu/hal/rtl8188e_phycfg.c |   3 -
 drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |   5 -
 drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |   8 +-
 drivers/staging/r8188eu/hal/usb_halinit.c     |  62 +--
 drivers/staging/r8188eu/hal/usb_ops_linux.c   |  31 +-
 drivers/staging/r8188eu/include/rtw_br_ext.h  |   5 -
 drivers/staging/r8188eu/include/rtw_debug.h   |   8 -
 drivers/staging/r8188eu/include/usb_ops.h     |   5 +-
 drivers/staging/r8188eu/os_dep/ioctl_linux.c  | 416 +-----------------
 drivers/staging/r8188eu/os_dep/mlme_linux.c   |   4 -
 drivers/staging/r8188eu/os_dep/os_intfs.c     |  34 +-
 .../staging/r8188eu/os_dep/osdep_service.c    |   2 -
 drivers/staging/r8188eu/os_dep/usb_intf.c     |  84 +---
 .../staging/r8188eu/os_dep/usb_ops_linux.c    |  18 +-
 drivers/staging/r8188eu/os_dep/xmit_linux.c   |   6 +-
 36 files changed, 166 insertions(+), 1687 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c

-- 
2.34.1

Re: [PATCH 00/10] Cleanup and removal of DBG_88E macro
Posted by Greg KH 4 years, 5 months ago
On Mon, Jan 24, 2022 at 10:44:05PM +0000, Phillip Potter wrote:
> This series does a few things in order to effect the removal of the
> DBG_88E macro:
> 
> (1) It removes previously converted calls for consistency.
> (2) It removes all current DBG_88E calls.
> (3) It removes all aliased DBG_88E calls.
> (4) It removes the GlobalDebugLevel flag and the file that defines it.
> 
> By its very nature, it is a large patchset, so I've tried to group as
> appropriate. I went by file as I did the work, which led to over 40
> patches originally, so I've listed the largest C files as their own
> patches and then grouped everything else by subdir which gives closer
> sizes for the other patches.

Can you rebase this on my staging-testing branch?  It no longer applies
:(

thanks,

greg k-h
Re: [PATCH 00/10] Cleanup and removal of DBG_88E macro
Posted by Phillip Potter 4 years, 5 months ago
On Tue, Jan 25, 2022 at 04:33:13PM +0100, Greg KH wrote:
> On Mon, Jan 24, 2022 at 10:44:05PM +0000, Phillip Potter wrote:
> > This series does a few things in order to effect the removal of the
> > DBG_88E macro:
> > 
> > (1) It removes previously converted calls for consistency.
> > (2) It removes all current DBG_88E calls.
> > (3) It removes all aliased DBG_88E calls.
> > (4) It removes the GlobalDebugLevel flag and the file that defines it.
> > 
> > By its very nature, it is a large patchset, so I've tried to group as
> > appropriate. I went by file as I did the work, which led to over 40
> > patches originally, so I've listed the largest C files as their own
> > patches and then grouped everything else by subdir which gives closer
> > sizes for the other patches.
> 
> Can you rebase this on my staging-testing branch?  It no longer applies
> :(
> 
> thanks,
> 
> greg k-h

Hi Greg,

Yes, of course - this was to supersede the previous 'conversion' patches
I sent so that is probably why it doesn't apply. Sorry, I did e-mail but
I should probably have made this clearer. I will fix it up over the next
few days, as it needs other changes anyway. Many thanks.

Regards,
Phil