[PATCH] pcmcia: rsrc_nonstatic: make static read-only array order const

Colin Ian King posted 1 patch 4 years, 5 months ago
drivers/pcmcia/rsrc_nonstatic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] pcmcia: rsrc_nonstatic: make static read-only array order const
Posted by Colin Ian King 4 years, 5 months ago
The static array is order read-only so it make sense to make
it const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/pcmcia/rsrc_nonstatic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
index 6b6c578b5f92..bde377655d48 100644
--- a/drivers/pcmcia/rsrc_nonstatic.c
+++ b/drivers/pcmcia/rsrc_nonstatic.c
@@ -480,7 +480,7 @@ static u_long inv_probe(struct resource_map *m, struct pcmcia_socket *s)
 static int validate_mem(struct pcmcia_socket *s, unsigned int probe_mask)
 {
 	struct resource_map *m, mm;
-	static unsigned char order[] = { 0xd0, 0xe0, 0xc0, 0xf0 };
+	static const unsigned char order[] = { 0xd0, 0xe0, 0xc0, 0xf0 };
 	unsigned long b, i, ok = 0;
 	struct socket_data *s_data = s->resource_data;
 
-- 
2.33.1

Re: [PATCH] pcmcia: rsrc_nonstatic: make static read-only array order const
Posted by Dominik Brodowski 4 years, 4 months ago
Am Sun, Jan 23, 2022 at 11:34:03PM +0000 schrieb Colin Ian King:
> The static array is order read-only so it make sense to make
> it const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

If it's read-only, it doesn't need to be static, right? Could you
update the patch and replace the static with const, please?

Thanks,
	Dominik