[PATCH] usb: gadget: at91_udc: fix incorrect print type

Miles Chen posted 1 patch 2 years, 8 months ago
drivers/usb/gadget/udc/at91_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] usb: gadget: at91_udc: fix incorrect print type
Posted by Miles Chen 2 years, 8 months ago
Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.

drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]

Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
 drivers/usb/gadget/udc/at91_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index dd0819df096e..9040a0561466 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
 					at91_vbus_irq, 0, driver_name, udc);
 			if (retval) {
 				DBG("request vbus irq %d failed\n",
-				    udc->board.vbus_pin);
+				    desc_to_gpio(udc->board.vbus_pin));
 				goto err_unprepare_iclk;
 			}
 		}
-- 
2.18.0

Re: [PATCH] usb: gadget: at91_udc: fix incorrect print type
Posted by Macpaul Lin 2 years, 8 months ago
On 1/19/22 10:08 AM, Miles Chen wrote:
> Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
> 
> drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
> 
> Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
>   drivers/usb/gadget/udc/at91_udc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index dd0819df096e..9040a0561466 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
>   					at91_vbus_irq, 0, driver_name, udc);
>   			if (retval) {
>   				DBG("request vbus irq %d failed\n",
> -				    udc->board.vbus_pin);
> +				    desc_to_gpio(udc->board.vbus_pin));
>   				goto err_unprepare_iclk;
>   			}
>   		}
> 

Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>

Thanks!
Macpaul Lin