dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example

[PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example

Posted by Rob Herring 4 years, 5 months ago

The 'interrupts' properties takes an irq number, not a phandle, and
'interrupt-parent' isn't needed in examples.
---
 Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
index 5dce62a7eff2..68c75a517c92 100644
--- a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
+++ b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
@@ -245,8 +245,7 @@ examples:
 
             interrupt-controller;
             #interrupt-cells = <2>;
-            interrupts = <&host_irq1>;
-            interrupt-parent = <&gic>;
+            interrupts = <4 1 0>;
 
             gpio-controller;
             #gpio-cells = <2>;
-- 
2.32.0

Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example

Posted by Charles Keepax 4 years, 5 months ago

On Tue, Jan 18, 2022 at 07:56:11PM -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example

Posted by Rob Herring 4 years, 5 months ago

On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---
>  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied (with my Sob added), thanks!

Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example

Posted by Lee Jones 4 years, 5 months ago

On Thu, 20 Jan 2022, Rob Herring wrote:

> On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> > The 'interrupts' properties takes an irq number, not a phandle, and
> > 'interrupt-parent' isn't needed in examples.
> > ---
> >  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Applied (with my Sob added), thanks!

Was going to say ... :)

Please add my Ack too:

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog