[PATCH v3 0/3] staging: pi433: validate min/max bit rate settings

Paulo Miguel Almeida posted 3 patches 4 years, 5 months ago
drivers/staging/pi433/TODO       |  2 ++
drivers/staging/pi433/pi433_if.c |  8 ++++----
drivers/staging/pi433/rf69.c     | 12 +++++++++---
3 files changed, 15 insertions(+), 7 deletions(-)
[PATCH v3 0/3] staging: pi433: validate min/max bit rate settings
Posted by Paulo Miguel Almeida 4 years, 5 months ago
RF69 chip supports different bit rate settings depending on which frequency
modulation is used. Failing to correctly validate bit rate can lead to a 
silent failure and cause packets not to be read/sent.

This series change the order in which the rf69 chip is configured and add
max bit rate validation.

Patch dependency:

This series depend on these patches as they change the same set of files:

- https://lore.kernel.org/lkml/20220108212728.GA7784@mail.google.com/
- https://lore.kernel.org/lkml/20220114221643.GA7843@mail.google.com/

Changelog:

v3: revert bitrate variable data type change. Req: Dan Carpenter
v2: change bitrate variable type to u32 as pointed by kernel test bot
v1: https://lore.kernel.org/lkml/20220116001726.GA22699@mail.google.com/

Paulo Miguel Almeida (3):
  staging: pi433: fix validation for min bit rate supported by the
    device
  staging: pi433: change order in which driver config the rf69 chip
  staging: pi433: validate max bit_rate based on modulation used

 drivers/staging/pi433/TODO       |  2 ++
 drivers/staging/pi433/pi433_if.c |  8 ++++----
 drivers/staging/pi433/rf69.c     | 12 +++++++++---
 3 files changed, 15 insertions(+), 7 deletions(-)

-- 
2.25.4

Re: [PATCH v3 0/3] staging: pi433: validate min/max bit rate settings
Posted by Dan Carpenter 4 years, 5 months ago
I'm fine with this.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

But please do add the note to the TODO.

regards,
dan carpenter
Re: [PATCH v3 0/3] staging: pi433: validate min/max bit rate settings
Posted by Paulo Miguel Almeida 4 years, 5 months ago
On Wed, Jan 19, 2022 at 09:04:00AM +0300, Dan Carpenter wrote:
> I'm fine with this.
> 
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> But please do add the note to the TODO.
> 
> regards,
> dan carpenter

Hi Dan, 

Thanks for the Acked-by. The TODO note was added on 0/3 of this patch
series:

https://lore.kernel.org/lkml/20220118230555.GA4961@mail.google.com/

thanks,

Paulo Almeida
Re: [PATCH v3 0/3] staging: pi433: validate min/max bit rate settings
Posted by Dan Carpenter 4 years, 5 months ago
On Sun, Jan 23, 2022 at 08:43:08PM +1300, Paulo Miguel Almeida wrote:
> On Wed, Jan 19, 2022 at 09:04:00AM +0300, Dan Carpenter wrote:
> > I'm fine with this.
> > 
> > Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > But please do add the note to the TODO.
> > 
> > regards,
> > dan carpenter
> 
> Hi Dan, 
> 
> Thanks for the Acked-by. The TODO note was added

Oh.  Sorry for not noticing that.  Thanks!

regards,
dan carpenter