[PATCH 5.16 00/28] 5.16.2-rc1 review

Greg Kroah-Hartman posted 28 patches 4 years, 5 months ago
Makefile                                           |  4 +-
arch/arm/kernel/perf_callchain.c                   | 17 ++++---
arch/arm64/kernel/perf_callchain.c                 | 18 +++++---
arch/csky/kernel/perf_callchain.c                  |  6 ++-
arch/nds32/kernel/perf_event_cpu.c                 | 17 ++++---
arch/riscv/kernel/perf_callchain.c                 |  7 ++-
arch/s390/kvm/interrupt.c                          |  7 +++
arch/s390/kvm/kvm-s390.c                           |  9 +++-
arch/s390/kvm/kvm-s390.h                           |  1 +
arch/s390/kvm/sigp.c                               | 28 ++++++++++++
arch/x86/events/core.c                             | 17 ++++---
arch/x86/events/intel/core.c                       |  9 ++--
arch/x86/include/asm/kvm_host.h                    |  1 +
arch/x86/kvm/lapic.c                               | 18 +++-----
arch/x86/kvm/vmx/vmx.c                             |  1 +
arch/x86/kvm/x86.c                                 | 12 +++--
drivers/base/devtmpfs.c                            |  7 +++
drivers/firmware/qemu_fw_cfg.c                     | 20 ++++-----
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  1 +
drivers/media/usb/uvc/uvc_video.c                  |  4 ++
.../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c    |  1 +
drivers/remoteproc/qcom_pil_info.c                 |  2 +-
drivers/remoteproc/qcom_q6v5_pas.c                 |  1 +
drivers/video/fbdev/vga16fb.c                      | 24 ++++++++++
fs/9p/vfs_addr.c                                   |  5 +++
fs/9p/vfs_inode_dotl.c                             | 29 ++++++++----
fs/fs_context.c                                    |  2 +-
fs/nfsd/nfs3proc.c                                 |  6 +--
fs/nfsd/nfsproc.c                                  |  5 ---
fs/orangefs/orangefs-bufmap.c                      |  7 ++-
fs/super.c                                         |  4 +-
include/linux/fs_context.h                         |  2 +
include/linux/perf_event.h                         | 13 +++++-
kernel/events/core.c                               | 13 ++++--
sound/pci/hda/hda_tegra.c                          | 43 ++++++++++++++----
sound/pci/hda/patch_realtek.c                      | 52 ++++++++++++++++++++--
tools/perf/ui/browsers/annotate.c                  | 23 ++++++----
37 files changed, 321 insertions(+), 115 deletions(-)
[PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Greg Kroah-Hartman 4 years, 5 months ago
This is the start of the stable review cycle for the 5.16.2 release.
There are 28 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 5.16.2-rc1

Takashi Iwai <tiwai@suse.de>
    ALSA: hda/realtek: Re-order quirk entries for Lenovo

Baole Fang <fbl718@163.com>
    ALSA: hda/realtek: Add quirk for Legion Y9000X 2020

Sameer Pujar <spujar@nvidia.com>
    ALSA: hda/tegra: Fix Tegra194 HDA reset failure

Bart Kroon <bart@tarmack.eu>
    ALSA: hda: ALC287: Add Lenovo IdeaPad Slim 9i 14ITL5 speaker quirk

Christian Lachner <gladiac@gmail.com>
    ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows

Kai-Heng Feng <kai.heng.feng@canonical.com>
    ALSA: hda/realtek: Use ALC285_FIXUP_HP_GPIO_LED on another HP laptop

Arie Geiger <arsgeiger@gmail.com>
    ALSA: hda/realtek: Add speaker fixup for some Yoga 15ITL5 devices

Dario Petrillo <dario.pk1@gmail.com>
    perf annotate: Avoid TUI crash when navigating in the annotation of recursive functions

Johan Hovold <johan@kernel.org>
    firmware: qemu_fw_cfg: fix kobject leak in probe error path

Johan Hovold <johan@kernel.org>
    firmware: qemu_fw_cfg: fix NULL-pointer deref on duplicate entries

Johan Hovold <johan@kernel.org>
    firmware: qemu_fw_cfg: fix sysfs information leak

Larry Finger <Larry.Finger@lwfinger.net>
    rtlwifi: rtl8192cu: Fix WARNING when calling local_irq_restore() with interrupts enabled

Johan Hovold <johan@kernel.org>
    media: uvcvideo: fix division by zero at stream start

Javier Martinez Canillas <javierm@redhat.com>
    video: vga16fb: Only probe for EGA and VGA 16 color graphic cards

Dominique Martinet <asmadeus@codewreck.org>
    9p: fix enodata when reading growing file

Christian Brauner <christian.brauner@ubuntu.com>
    9p: only copy valid iattrs in 9P2000.L setattr implementation

Chuck Lever <chuck.lever@oracle.com>
    NFSD: Fix zero-length NFSv3 WRITEs

Sibi Sankar <sibis@codeaurora.org>
    remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

Eric Farman <farman@linux.ibm.com>
    KVM: s390: Clarify SIGP orders versus STOP/RESTART

Li RongQing <lirongqing@baidu.com>
    KVM: x86: don't print when fail to read/write pv eoi memory

Sean Christopherson <seanjc@google.com>
    KVM: x86: Register Processor Trace interrupt hook iff PT enabled in guest

Sean Christopherson <seanjc@google.com>
    KVM: x86: Register perf callbacks after calling vendor's hardware_setup()

Sean Christopherson <seanjc@google.com>
    perf: Protect perf_guest_cbs with RCU

Jamie Hill-Daniel <jamie@hill-daniel.co.uk>
    vfs: fs_context: fix up param length parsing in legacy_parse_param

Stephen Boyd <swboyd@chromium.org>
    remoteproc: qcom: pil_info: Don't memcpy_toio more than is provided

Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()

Mario Limonciello <mario.limonciello@amd.com>
    drm/amd/display: explicitly set is_dsc_supported to false before use

NeilBrown <neilb@suse.de>
    devtmpfs regression fix: reconfigure on each mount


-------------

Diffstat:

 Makefile                                           |  4 +-
 arch/arm/kernel/perf_callchain.c                   | 17 ++++---
 arch/arm64/kernel/perf_callchain.c                 | 18 +++++---
 arch/csky/kernel/perf_callchain.c                  |  6 ++-
 arch/nds32/kernel/perf_event_cpu.c                 | 17 ++++---
 arch/riscv/kernel/perf_callchain.c                 |  7 ++-
 arch/s390/kvm/interrupt.c                          |  7 +++
 arch/s390/kvm/kvm-s390.c                           |  9 +++-
 arch/s390/kvm/kvm-s390.h                           |  1 +
 arch/s390/kvm/sigp.c                               | 28 ++++++++++++
 arch/x86/events/core.c                             | 17 ++++---
 arch/x86/events/intel/core.c                       |  9 ++--
 arch/x86/include/asm/kvm_host.h                    |  1 +
 arch/x86/kvm/lapic.c                               | 18 +++-----
 arch/x86/kvm/vmx/vmx.c                             |  1 +
 arch/x86/kvm/x86.c                                 | 12 +++--
 drivers/base/devtmpfs.c                            |  7 +++
 drivers/firmware/qemu_fw_cfg.c                     | 20 ++++-----
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  1 +
 drivers/media/usb/uvc/uvc_video.c                  |  4 ++
 .../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c    |  1 +
 drivers/remoteproc/qcom_pil_info.c                 |  2 +-
 drivers/remoteproc/qcom_q6v5_pas.c                 |  1 +
 drivers/video/fbdev/vga16fb.c                      | 24 ++++++++++
 fs/9p/vfs_addr.c                                   |  5 +++
 fs/9p/vfs_inode_dotl.c                             | 29 ++++++++----
 fs/fs_context.c                                    |  2 +-
 fs/nfsd/nfs3proc.c                                 |  6 +--
 fs/nfsd/nfsproc.c                                  |  5 ---
 fs/orangefs/orangefs-bufmap.c                      |  7 ++-
 fs/super.c                                         |  4 +-
 include/linux/fs_context.h                         |  2 +
 include/linux/perf_event.h                         | 13 +++++-
 kernel/events/core.c                               | 13 ++++--
 sound/pci/hda/hda_tegra.c                          | 43 ++++++++++++++----
 sound/pci/hda/patch_realtek.c                      | 52 ++++++++++++++++++++--
 tools/perf/ui/browsers/annotate.c                  | 23 ++++++----
 37 files changed, 321 insertions(+), 115 deletions(-)


Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Jeffrin Jose T 4 years, 5 months ago
On Tue, 2022-01-18 at 17:05 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
>         
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
> stable-rc.git linux-5.16.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
 hello ,

Compiled  and booted  5.16.2-rc1+ on VivoBook 15_ASUS Laptop X507UAR
.No Regression  from dmesg, except an old warning
 
Tested-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>

-- 
software engineer
rajagiri school of engineering and technology - autonomous
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Rudi Heitbaum 4 years, 5 months ago
On Tue, Jan 18, 2022 at 05:05:55PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.


Hi Greg,

Looking good.

Run tested on:
- Allwinner H6 (Tanix TX6)
- Intel Tiger Lake x86_64 (nuc11 i7-1165G7)

In addition: build tested on:
- Allwinner A64
- Allwinner H3
- Allwinner H5
- NXP iMX6
- NXP iMX8
- Qualcomm Dragonboard
- Rockchip RK3288
- Rockchip RK3328
- Rockchip RK3399pro
- Samsung Exynos

Tested-by: Rudi Heitbaum <rudi@heitbaum.com>
--
Rudi
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Guenter Roeck 4 years, 5 months ago
On Tue, Jan 18, 2022 at 05:05:55PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
> 

Build results:
	total: 153 pass: 153 fail: 0
Qemu test results:
	total: 485 pass: 485 fail: 0

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Naresh Kamboju 4 years, 5 months ago
On Tue, 18 Jan 2022 at 21:41, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 5.16.2-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.16.y
* git commit: 979dd812ffb543a3f6218868a26a701054ba3b8c
* git describe: v5.16-67-g979dd812ffb5
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.16.y/build/v5.16-67-g979dd812ffb5

## Test Regressions (compared to v5.16.1)
No test regressions found.

## Metric Regressions (compared to v5.16.1)
No metric regressions found.

## Test Fixes (compared to v5.16.1)
No test fixes found.

## Metric Fixes (compared to v5.16.1)
No metric fixes found.

## Test result summary
total: 95183, pass: 81363, fail: 867, skip: 12040, xfail: 913

## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 263 total, 242 passed, 21 failed
* arm64: 42 total, 42 passed, 0 failed
* i386: 39 total, 36 passed, 3 failed
* mips: 37 total, 31 passed, 6 failed
* parisc: 14 total, 14 passed, 0 failed
* powerpc: 56 total, 48 passed, 8 failed
* riscv: 28 total, 24 passed, 4 failed
* s390: 22 total, 20 passed, 2 failed
* sh: 26 total, 24 passed, 2 failed
* sparc: 14 total, 14 passed, 0 failed
* x86_64: 42 total, 42 passed, 0 failed

## Test suites summary
* fwts
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-arm64/arm64.btitest.bti_c_func
* kselftest-arm64/arm64.btitest.bti_j_func
* kselftest-arm64/arm64.btitest.bti_jc_func
* kselftest-arm64/arm64.btitest.bti_none_func
* kselftest-arm64/arm64.btitest.nohint_func
* kselftest-arm64/arm64.btitest.paciasp_func
* kselftest-arm64/arm64.nobtitest.bti_c_func
* kselftest-arm64/arm64.nobtitest.bti_j_func
* kselftest-arm64/arm64.nobtitest.bti_jc_func
* kselftest-arm64/arm64.nobtitest.bti_none_func
* kselftest-arm64/arm64.nobtitest.nohint_func
* kselftest-arm64/arm64.nobtitest.paciasp_func
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-net
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* perf
* rcutorture
* ssuite
* v4l2-compliance

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Ron Economos 4 years, 5 months ago
On 1/18/22 8:05 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Built and booted successfully on RISC-V RV64 (HiFive Unmatched).

Tested-by: Ron Economos <re@w6rz.net>

Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Naresh Kamboju 4 years, 5 months ago
On Tue, 18 Jan 2022 at 21:41, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Following patch caused build regression for powerpc allnoconfig only on 5.16
with gcc-9.

5.16-powerpc-gcc-9-allnoconfig   - FAIL
5.16-powerpc-gcc-10-allnoconfig  - PASS
5.16-powerpc-gcc-11-allnoconfig  - PASS


make --silent --keep-going --jobs=8 \
  O=/home/tuxbuild/.cache/tuxmake/builds/current \
  ARCH=powerpc \
  CROSS_COMPILE=powerpc64le-linux-gnu- \
 'CC=sccache powerpc64le-linux-gnu-gcc' \
  'HOSTCC=sccache gcc'

Inconsistent kallsyms data
Try make KALLSYMS_EXTRA_PASS=1 as a workaround
make[1]: *** [/builds/linux/Makefile:1161: vmlinux] Error 1
make[1]: *** Deleting file 'vmlinux'

> NeilBrown <neilb@suse.de>
>     devtmpfs regression fix: reconfigure on each mount

Bisect log:
# bad: [979dd812ffb543a3f6218868a26a701054ba3b8c] Linux 5.16.2-rc1
# good: [80820ae87cc8c09b828faa951f44b2396a5b48c4] drm/i915: Avoid
bitwise vs logical OR warning in snb_wm_latency_quirk()
git bisect start '979dd812ffb543a3f6218868a26a701054ba3b8c'
'80820ae87cc8c09b828faa951f44b2396a5b48c4'
# bad: [6cb89b83384df47b2def88870be10db707a77649] 9p: only copy valid
iattrs in 9P2000.L setattr implementation
git bisect bad 6cb89b83384df47b2def88870be10db707a77649
# bad: [041b83007bd86ba0e7275e348eb13df13df669ef] vfs: fs_context: fix
up param length parsing in legacy_parse_param
git bisect bad 041b83007bd86ba0e7275e348eb13df13df669ef
# bad: [a7458144427accc2b602a672b1f9435e00ba578e] devtmpfs regression
fix: reconfigure on each mount
git bisect bad a7458144427accc2b602a672b1f9435e00ba578e
# good: [5c245afa643712977fd0a9c70ffbb9df5dbf204b] parisc: Fix
pdc_toc_pim_11 and pdc_toc_pim_20 definitions
git bisect good 5c245afa643712977fd0a9c70ffbb9df5dbf204b
# good: [677615cd2689a0898dd58e51d12abe6663567b24] Linux 5.16.1
git bisect good 677615cd2689a0898dd58e51d12abe6663567b24
# first bad commit: [a7458144427accc2b602a672b1f9435e00ba578e]
devtmpfs regression fix: reconfigure on each mount
The first bad commit:
commit a7458144427accc2b602a672b1f9435e00ba578e
Author: NeilBrown <neilb@suse.de>
Date:   Mon Jan 17 09:07:26 2022 +1100
    devtmpfs regression fix: reconfigure on each mount

    commit a6097180d884ddab769fb25588ea8598589c218c upstream.

    Prior to Linux v5.4 devtmpfs used mount_single() which treats the given
    mount options as "remount" options, so it updates the configuration of
    the single super_block on each mount.

    Since that was changed, the mount options used for devtmpfs are ignored.
    This is a regression which affect systemd - which mounts devtmpfs with
    "-o mode=755,size=4m,nr_inodes=1m".

    This patch restores the "remount" effect by calling reconfigure_single()

    Fixes: d401727ea0d7 ("devtmpfs: don't mix
{ramfs,shmem}_fill_super() with mount_single()")
    Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 drivers/base/devtmpfs.c    | 7 +++++++
 fs/super.c                 | 4 ++--
 include/linux/fs_context.h | 2 ++
 3 files changed, 11 insertions(+), 2 deletions(-)

you may compare build results here.
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.16.y/build/v5.16-67-g979dd812ffb5/testrun/7410428/suite/build/test/gcc-9-allnoconfig/history/

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Linus Torvalds 4 years, 5 months ago
On Wed, Jan 19, 2022 at 9:30 AM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> Inconsistent kallsyms data

This tends to be a "odd build environment" problem, and very very
random. Triggered by very particular compiler versions and just some
odd code modement details.

I'd suggest doing a completely clean build and disabling ccache, and
seeing if that makes it go away.

              Linus
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Guenter Roeck 4 years, 5 months ago
On 1/18/22 11:53 PM, Linus Torvalds wrote:
> On Wed, Jan 19, 2022 at 9:30 AM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
>>
>> Inconsistent kallsyms data
> 
> This tends to be a "odd build environment" problem, and very very
> random. Triggered by very particular compiler versions and just some
> odd code modement details.
> 

It happens once in a while depending on the compiler version and
on how symbols are arranged, and new compiler specific symbols showing up.
I had submitted a patch a while ago that kept retrying a few more times
before giving up (that was rejected). We carry a patch in ChromeOS kernels
which tells us what the offending symbols are in case we see the problem
in our builds.

> I'd suggest doing a completely clean build and disabling ccache, and
> seeing if that makes it go away.
> 

My experience is that once it starts, it will show up randomly and become
more and more prevalent over time until almost all builds fail. powerpc
seems to be affected a lot by this problem, but we have also seen it
on x86. When that happens, someone has to go in and figure out the
offending symbol(s) and add it or them to some exception list.

Guenter
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Anders Roxell 4 years, 5 months ago
On Wed, 19 Jan 2022 at 09:00, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Wed, Jan 19, 2022 at 9:30 AM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > Inconsistent kallsyms data
>
> This tends to be a "odd build environment" problem, and very very
> random. Triggered by very particular compiler versions and just some
> odd code modement details.
>
> I'd suggest doing a completely clean build and disabling ccache, and
> seeing if that makes it go away.

Clean build without ccache didn't help.

It seams that it fails randomly based on the size of the rodata section.
This could probably happen with another toolchain too, trying enough
configurations.

Diff of tmp_vmlinux.kallsyms2.symbols and
tmp_vmlinux.kallsyms3.symbols [1] show why it fails to converge, while
said that the __stop_notes address is on the page boundary, so
__end_rodata has the same value as __stop_notes.
All 3 tmp_vmlinux.kallsyms(1|2|3).symbols files can be found [2].

Inserting padding before __end_rodata [3], or blacklisting __stop_notes [4]
in kallsyms.c works around the problem, but neither of those seems like a
good fix.

The linker version I'm using are 'GNU ld (GNU Binutils for Debian) 2.35.2'.

Cheers,
Anders
[1] http://ix.io/3ML7
[2] https://people.linaro.org/~anders.roxell/kallsyms/
[3] http://ix.io/3MN2
[4] http://ix.io/3MN4
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Zan Aziz 4 years, 5 months ago
On Tue, Jan 18, 2022 at 9:17 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Hi Greg,

Compiled and booted on my test system Lenovo P50s: Intel Core i7
No emergency and critical messages in the dmesg
I am going to be running perf bench sched from now on and I will
report any regressions

./perf bench sched all
# Running sched/messaging benchmark...
# 20 sender and receiver processes per group
# 10 groups == 400 processes run

     Total time: 0.437 [sec]

# Running sched/pipe benchmark...
# Executed 1000000 pipe operations between two processes

     Total time: 6.919 [sec]

       6.919489 usecs/op
         144519 ops/sec

Tested-by: Zan Aziz <zanaziz313@gmail.com>

Thanks
-Zan
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Shuah Khan 4 years, 5 months ago
On 1/18/22 9:05 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
Re: [PATCH 5.16 00/28] 5.16.2-rc1 review
Posted by Florian Fainelli 4 years, 5 months ago
On 1/18/22 8:05 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels:

Tested-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian