[PATCH v3 0/2] ext4: fix issues when fast commit work with jbd

Xin Yin posted 2 patches 4 years, 5 months ago
fs/ext4/ext4.h        |  8 +++-----
fs/ext4/extents.c     |  4 ++--
fs/ext4/fast_commit.c | 44 ++++++++++++++++++++++++++++++-------------
fs/ext4/inode.c       |  4 ++--
fs/ext4/ioctl.c       |  4 ++--
fs/ext4/namei.c       |  4 ++--
fs/ext4/super.c       |  2 +-
fs/ext4/xattr.c       |  6 +++---
fs/jbd2/commit.c      |  2 +-
fs/jbd2/journal.c     |  2 +-
include/linux/jbd2.h  |  2 +-
11 files changed, 49 insertions(+), 33 deletions(-)
[PATCH v3 0/2] ext4: fix issues when fast commit work with jbd
Posted by Xin Yin 4 years, 5 months ago
When test fast commit with xfstests generic/455, some logic issues were
found. When a full commit is ongonig, the logic of fast commit tracking seems
not correct. The first patch fix the ineligible commit case , and the
second patch fix the common fast commit case.

After testing this patch set with xfstests log and quick group, no 
regressions were found, and the generic/455 can pass now.

---
v2: drop EXT4_MF_FC_COMMITTING
v3: change logic of ext4_fc_mark_ineligible() when set 'handle' as NULL.
Fix use-after-free issue for improper use of 'handle' for
ext4_fc_mark_ineligible().

Xin Yin (2):
  ext4: fast commit may not fallback for ineligible commit
  ext4: fast commit may miss file actions

 fs/ext4/ext4.h        |  8 +++-----
 fs/ext4/extents.c     |  4 ++--
 fs/ext4/fast_commit.c | 44 ++++++++++++++++++++++++++++++-------------
 fs/ext4/inode.c       |  4 ++--
 fs/ext4/ioctl.c       |  4 ++--
 fs/ext4/namei.c       |  4 ++--
 fs/ext4/super.c       |  2 +-
 fs/ext4/xattr.c       |  6 +++---
 fs/jbd2/commit.c      |  2 +-
 fs/jbd2/journal.c     |  2 +-
 include/linux/jbd2.h  |  2 +-
 11 files changed, 49 insertions(+), 33 deletions(-)

-- 
2.25.1

Re: [PATCH v3 0/2] ext4: fix issues when fast commit work with jbd
Posted by Theodore Ts'o 4 years, 5 months ago
On Mon, 17 Jan 2022 17:36:53 +0800, Xin Yin wrote:
> When test fast commit with xfstests generic/455, some logic issues were
> found. When a full commit is ongonig, the logic of fast commit tracking seems
> not correct. The first patch fix the ineligible commit case , and the
> second patch fix the common fast commit case.
> 
> After testing this patch set with xfstests log and quick group, no
> regressions were found, and the generic/455 can pass now.
> 
> [...]

Applied, thanks!

[1/2] ext4: fast commit may not fallback for ineligible commit
      commit: b4facf2d8a22262f945975d23e29bbfa94ab5d27
[2/2] ext4: fast commit may miss file actions
      commit: 4a404adb1978f0a3f2ec9ee6c257bcc5b2452ee3

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>