perf cpumap: remove duplicate include in cpumap.h

[PATCH] perf cpumap: remove duplicate include in cpumap.h

Posted by cgel.zte@gmail.com 4 years, 5 months ago

From: Lv Ruyi <lv.ruyi@zte.com.cn>

Remove all but the first include of stdbool.h from cpumap.h.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
 tools/perf/util/cpumap.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
index 0d3c2006a15d..240db1da370c 100644
--- a/tools/perf/util/cpumap.h
+++ b/tools/perf/util/cpumap.h
@@ -4,7 +4,6 @@
 
 #include <stdbool.h>
 #include <stdio.h>
-#include <stdbool.h>
 #include <internal/cpumap.h>
 #include <perf/cpumap.h>
 
-- 
2.25.1

Re: [PATCH] perf cpumap: remove duplicate include in cpumap.h

Posted by Ian Rogers 4 years, 5 months ago

On Mon, Jan 17, 2022 at 12:37 AM <cgel.zte@gmail.com> wrote:
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> Remove all but the first include of stdbool.h from cpumap.h.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/util/cpumap.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> index 0d3c2006a15d..240db1da370c 100644
> --- a/tools/perf/util/cpumap.h
> +++ b/tools/perf/util/cpumap.h
> @@ -4,7 +4,6 @@
>
>  #include <stdbool.h>
>  #include <stdio.h>
> -#include <stdbool.h>
>  #include <internal/cpumap.h>
>  #include <perf/cpumap.h>
>
> --
> 2.25.1
>

Re: [PATCH] perf cpumap: remove duplicate include in cpumap.h

Posted by Arnaldo Carvalho de Melo 4 years, 5 months ago

Em Mon, Jan 17, 2022 at 08:31:12AM -0800, Ian Rogers escreveu:
> On Mon, Jan 17, 2022 at 12:37 AM <cgel.zte@gmail.com> wrote:
> >
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >
> > Remove all but the first include of stdbool.h from cpumap.h.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/util/cpumap.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
> > index 0d3c2006a15d..240db1da370c 100644
> > --- a/tools/perf/util/cpumap.h
> > +++ b/tools/perf/util/cpumap.h
> > @@ -4,7 +4,6 @@
> >
> >  #include <stdbool.h>
> >  #include <stdio.h>
> > -#include <stdbool.h>
> >  #include <internal/cpumap.h>
> >  #include <perf/cpumap.h>
> >
> > --
> > 2.25.1
> >

-- 

- Arnaldo