[PATCH] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls

Xu Wang posted 1 patch 4 years, 5 months ago
drivers/soc/qcom/apr.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls
Posted by Xu Wang 4 years, 5 months ago
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/soc/qcom/apr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
index 82ca12c9328a..3caabd873322 100644
--- a/drivers/soc/qcom/apr.c
+++ b/drivers/soc/qcom/apr.c
@@ -653,7 +653,6 @@ static void apr_remove(struct rpmsg_device *rpdev)
 
 	pdr_handle_release(apr->pdr);
 	device_for_each_child(&rpdev->dev, NULL, apr_remove_device);
-	flush_workqueue(apr->rxwq);
 	destroy_workqueue(apr->rxwq);
 }
 
-- 
2.25.1

Re: (subset) [PATCH] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls
Posted by Bjorn Andersson 4 years, 4 months ago
On Fri, 14 Jan 2022 08:50:19 +0000, Xu Wang wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> 

Applied, thanks!

[1/1] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls
      commit: 4e6ae78ee61957800657d56ba78a10f034de174e

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>