[v2] media: coda: Fix missing put_device() call in coda_get_vdoa_data

[PATCH v2] media: coda: Fix missing put_device() call in coda_get_vdoa_data

Miaoqian Lin posted 1 patch 4 years, 5 months ago

Diff against v1
Download mbox

drivers/media/platform/coda/coda-common.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH v2] media: coda: Fix missing put_device() call in coda_get_vdoa_data

Posted by Miaoqian Lin 4 years, 5 months ago

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
Changes in v2:
- remove the goto and unused label.
---
 drivers/media/platform/coda/coda-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index 0e312b0842d7..c3942b0abb00 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -408,6 +408,7 @@ static struct vdoa_data *coda_get_vdoa_data(void)
 	if (!vdoa_data)
 		vdoa_data = ERR_PTR(-EPROBE_DEFER);
 
+	put_device(&vdoa_pdev->dev);
 out:
 	of_node_put(vdoa_node);
 
-- 
2.17.1