media: i2c: remove unneeded variable

[PATCH] media: i2c: remove unneeded variable

Posted by cgel.zte@gmail.com 4 years, 5 months ago

From: Changcheng Deng <deng.changcheng@zte.com.cn>

Remove unneeded variable used to store return value.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
 drivers/media/i2c/ov5693.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
index 2784fcf67f3b..a55910f6283a 100644
--- a/drivers/media/i2c/ov5693.c
+++ b/drivers/media/i2c/ov5693.c
@@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
 	unsigned int width, height;
 	unsigned int hblank;
 	int exposure_max;
-	int ret = 0;
 
 	crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
 
@@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
 	format->format = *fmt;
 
 	if (format->which == V4L2_SUBDEV_FORMAT_TRY)
-		return ret;
+		return 0;
 
 	mutex_lock(&ov5693->lock);
 
@@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
 				     exposure_max));
 
 	mutex_unlock(&ov5693->lock);
-	return ret;
+	return 0;
 }
 
 static int ov5693_get_selection(struct v4l2_subdev *sd,
-- 
2.25.1

Re: [PATCH] media: i2c: remove unneeded variable

Posted by Hans Verkuil 4 years, 5 months ago

On 12/01/2022 10:17, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Remove unneeded variable used to store return value.

Please add the driver name in the subject prefix! Why is that so hard to
remember?

Regards,

	Hans

> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
>  drivers/media/i2c/ov5693.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 2784fcf67f3b..a55910f6283a 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	unsigned int width, height;
>  	unsigned int hblank;
>  	int exposure_max;
> -	int ret = 0;
>  
>  	crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
>  
> @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	format->format = *fmt;
>  
>  	if (format->which == V4L2_SUBDEV_FORMAT_TRY)
> -		return ret;
> +		return 0;
>  
>  	mutex_lock(&ov5693->lock);
>  
> @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  				     exposure_max));
>  
>  	mutex_unlock(&ov5693->lock);
> -	return ret;
> +	return 0;
>  }
>  
>  static int ov5693_get_selection(struct v4l2_subdev *sd,

Re: [PATCH] media: i2c: remove unneeded variable

Posted by Daniel Scally 4 years, 5 months ago

Hello

On 12/01/2022 09:17, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>

Yeah good catch. With Hans' comment about the subject line addressed:

Reviewed-by: Daniel Scally <djrscally@gmail.com>

> ---
>  drivers/media/i2c/ov5693.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 2784fcf67f3b..a55910f6283a 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	unsigned int width, height;
>  	unsigned int hblank;
>  	int exposure_max;
> -	int ret = 0;
>  
>  	crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
>  
> @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	format->format = *fmt;
>  
>  	if (format->which == V4L2_SUBDEV_FORMAT_TRY)
> -		return ret;
> +		return 0;
>  
>  	mutex_lock(&ov5693->lock);
>  
> @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  				     exposure_max));
>  
>  	mutex_unlock(&ov5693->lock);
> -	return ret;
> +	return 0;
>  }
>  
>  static int ov5693_get_selection(struct v4l2_subdev *sd,
>