[PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings

Krzysztof Kozlowski posted 5 patches 4 years, 5 months ago
.../bindings/extcon/maxim,max77843.yaml       |  40 +++++
.../bindings/mfd/maxim,max77843.yaml          | 144 ++++++++++++++++++
.../bindings/regulator/maxim,max77843.yaml    |  65 ++++++++
MAINTAINERS                                   |   2 +
.../dts/exynos/exynos5433-tm2-common.dtsi     |  17 ++-
5 files changed, 265 insertions(+), 3 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
[PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Krzysztof Kozlowski 4 years, 5 months ago
Hi,

The max77843 shares some parts with max77693 but it lacked bindings.  All
its compatibles were undocumented.  Add basic bindings for max77843,
matching existing devicetree.  These are not complete bindings, but
rather reverse-engineered to match current state.

I do not have access to device with MAX77843, so if anyone else
volunteers to be the bindings maintainer, please join.

Changes since v1
================
1. MFD: Use absolute path to schemas.
2. Regulator: mention all allowed properties,
   additionalProperties=false, add min/max values for voltages and
   current, don't use patternProperties when not needed.
3. extcon: Use absolute path to schemas.

Dependencies
============
1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
   checker won't complain about DTS.
   I will take it via Samsung SoC tree.

2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
   should come together (2+3+4+5).

Best regards,
Krzysztof

Krzysztof Kozlowski (5):
  arm64: dts: exynos: Align MAX77843 nodes with dtschema on TM2
  dt-bindings: extcon: maxim,max77843: add MAX77843 bindings
  regulator: dt-bindings: maxim,max77843: add MAX77843 bindings
  dt-bindings: mfd: maxim,max77843: add MAX77843 bindings
  MAINTAINERS: mfd: cover MAX77843 by Maxim PMIC/MUIC for Exynos boards
    entry

 .../bindings/extcon/maxim,max77843.yaml       |  40 +++++
 .../bindings/mfd/maxim,max77843.yaml          | 144 ++++++++++++++++++
 .../bindings/regulator/maxim,max77843.yaml    |  65 ++++++++
 MAINTAINERS                                   |   2 +
 .../dts/exynos/exynos5433-tm2-common.dtsi     |  17 ++-
 5 files changed, 265 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml

-- 
2.32.0

Re: [PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Krzysztof Kozlowski 4 years, 4 months ago
On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> Hi,
> 
> The max77843 shares some parts with max77693 but it lacked bindings.  All
> its compatibles were undocumented.  Add basic bindings for max77843,
> matching existing devicetree.  These are not complete bindings, but
> rather reverse-engineered to match current state.
> 
> I do not have access to device with MAX77843, so if anyone else
> volunteers to be the bindings maintainer, please join.
> 
> Changes since v1
> ================
> 1. MFD: Use absolute path to schemas.
> 2. Regulator: mention all allowed properties,
>    additionalProperties=false, add min/max values for voltages and
>    current, don't use patternProperties when not needed.
> 3. extcon: Use absolute path to schemas.
> 
> Dependencies
> ============
> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
>    checker won't complain about DTS.
>    I will take it via Samsung SoC tree.
> 
> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
>    should come together (2+3+4+5).
> 
Dear Lee,

This patchset was reviewed and there are no outstanding issues. Could
you pick up patches 2-5 (skipping DTS patch) via MFD tree?

Best regards,
Krzysztof

Re: [PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Lee Jones 4 years, 4 months ago
On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:

> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> > Hi,
> > 
> > The max77843 shares some parts with max77693 but it lacked bindings.  All
> > its compatibles were undocumented.  Add basic bindings for max77843,
> > matching existing devicetree.  These are not complete bindings, but
> > rather reverse-engineered to match current state.
> > 
> > I do not have access to device with MAX77843, so if anyone else
> > volunteers to be the bindings maintainer, please join.
> > 
> > Changes since v1
> > ================
> > 1. MFD: Use absolute path to schemas.
> > 2. Regulator: mention all allowed properties,
> >    additionalProperties=false, add min/max values for voltages and
> >    current, don't use patternProperties when not needed.
> > 3. extcon: Use absolute path to schemas.
> > 
> > Dependencies
> > ============
> > 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
> >    checker won't complain about DTS.
> >    I will take it via Samsung SoC tree.
> > 
> > 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
> >    should come together (2+3+4+5).
> > 
> Dear Lee,
> 
> This patchset was reviewed and there are no outstanding issues. Could
> you pick up patches 2-5 (skipping DTS patch) via MFD tree?

Are the subsystem maintainers not going to review/ack?

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Krzysztof Kozlowski 4 years, 4 months ago
On 07/02/2022 10:33, Lee Jones wrote:
> On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:
> 
>> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> The max77843 shares some parts with max77693 but it lacked bindings.  All
>>> its compatibles were undocumented.  Add basic bindings for max77843,
>>> matching existing devicetree.  These are not complete bindings, but
>>> rather reverse-engineered to match current state.
>>>
>>> I do not have access to device with MAX77843, so if anyone else
>>> volunteers to be the bindings maintainer, please join.
>>>
>>> Changes since v1
>>> ================
>>> 1. MFD: Use absolute path to schemas.
>>> 2. Regulator: mention all allowed properties,
>>>    additionalProperties=false, add min/max values for voltages and
>>>    current, don't use patternProperties when not needed.
>>> 3. extcon: Use absolute path to schemas.
>>>
>>> Dependencies
>>> ============
>>> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
>>>    checker won't complain about DTS.
>>>    I will take it via Samsung SoC tree.
>>>
>>> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
>>>    should come together (2+3+4+5).
>>>
>> Dear Lee,
>>
>> This patchset was reviewed and there are no outstanding issues. Could
>> you pick up patches 2-5 (skipping DTS patch) via MFD tree?
> 
> Are the subsystem maintainers not going to review/ack?
> 

Would be nice to have them, but maybe since these are dt-bindings maybe
they were skipped? Or maybe it was the end-of-year holidays?

I can resend hoping it will trigger more acks. Do you wish me to resend?

Best regards,
Krzysztof
Re: [PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Lee Jones 4 years, 4 months ago
On Mon, 07 Feb 2022, Krzysztof Kozlowski wrote:

> On 07/02/2022 10:33, Lee Jones wrote:
> > On Sun, 06 Feb 2022, Krzysztof Kozlowski wrote:
> > 
> >> On 11/01/2022 18:48, Krzysztof Kozlowski wrote:
> >>> Hi,
> >>>
> >>> The max77843 shares some parts with max77693 but it lacked bindings.  All
> >>> its compatibles were undocumented.  Add basic bindings for max77843,
> >>> matching existing devicetree.  These are not complete bindings, but
> >>> rather reverse-engineered to match current state.
> >>>
> >>> I do not have access to device with MAX77843, so if anyone else
> >>> volunteers to be the bindings maintainer, please join.
> >>>
> >>> Changes since v1
> >>> ================
> >>> 1. MFD: Use absolute path to schemas.
> >>> 2. Regulator: mention all allowed properties,
> >>>    additionalProperties=false, add min/max values for voltages and
> >>>    current, don't use patternProperties when not needed.
> >>> 3. extcon: Use absolute path to schemas.
> >>>
> >>> Dependencies
> >>> ============
> >>> 1. Patch 1/5 (dts): nothing depends on it, sending here so Rob's automatic
> >>>    checker won't complain about DTS.
> >>>    I will take it via Samsung SoC tree.
> >>>
> >>> 2. The patch 4/5 (mfd bindings) depends on regulator and extcon, so they
> >>>    should come together (2+3+4+5).
> >>>
> >> Dear Lee,
> >>
> >> This patchset was reviewed and there are no outstanding issues. Could
> >> you pick up patches 2-5 (skipping DTS patch) via MFD tree?
> > 
> > Are the subsystem maintainers not going to review/ack?
> > 
> 
> Would be nice to have them, but maybe since these are dt-bindings maybe
> they were skipped? 

Agreed, not required, but nice to have to avoid possible conflict.

> Or maybe it was the end-of-year holidays?

> I can resend hoping it will trigger more acks. Do you wish me to resend?

That shouldn't be necessary.

I'll give the guys a little while to protest/ack, then I'll merge.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 0/5] mfd/extcon/regulators: max77843: add dtschema/bindings
Posted by Mark Brown 4 years, 4 months ago
On Mon, Feb 07, 2022 at 10:47:00AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:33, Lee Jones wrote:

> > Are the subsystem maintainers not going to review/ack?

> Would be nice to have them, but maybe since these are dt-bindings maybe
> they were skipped? Or maybe it was the end-of-year holidays?

You've been sending out a large number of very similar serieses, each of
which is going through multiple revisions - it's hard to keep track of
what's been reviewed, what's in a state where it's useful to review

> I can resend hoping it will trigger more acks. Do you wish me to resend?

It's probably going to add more noise, on the other hand some things
might've been dropped on the floor due to the similarity and whatnot.
[GIT PULL] Immutable branch between MFD, SPI and DT due for the v5.18 merge window
Posted by Lee Jones 4 years, 3 months ago
Enjoy!

The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07:

  Linux 5.17-rc1 (2022-01-23 10:12:53 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-spi-dt-v5.18

for you to fetch changes up to 172e611b54e813c49a35b6b74bccaa99f27bf566:

  dt-bindings: mfd: maxim,max77802: Convert to dtschema (2022-03-07 12:55:59 +0000)

----------------------------------------------------------------
Immutable branch between MFD, SPI and DT  due for the v5.18 merge window

----------------------------------------------------------------
Krzysztof Kozlowski (13):
      dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings
      regulator: dt-bindings: maxim,max77843: Add MAX77843 bindings
      dt-bindings: mfd: maxim,max77843: Add MAX77843 bindings
      MAINTAINERS: mfd: Cover MAX77843 by Maxim PMIC/MUIC for Exynos boards entry
      spi: dt-bindings: samsung: Convert to dtschema
      mfd: dt-bindings: google,cros-ec: Reference Samsung SPI bindings
      mfd: dt-bindings: google,cros-ec: Fix indentation in example
      spi: s3c64xx: Allow controller-data to be optional
      dt-bindings: power: supply: maxim,max14577: Convert to dtschema
      regulator: dt-bindings: maxim,max14577: Convert to dtschema
      dt-bindings: mfd: maxim,max14577: Convert to dtschema
      regulator: dt-bindings: maxim,max77802: Convert to dtschema
      dt-bindings: mfd: maxim,max77802: Convert to dtschema

 .../devicetree/bindings/extcon/maxim,max77843.yaml |  40 +++++
 .../devicetree/bindings/mfd/google,cros-ec.yaml    |  31 ++--
 Documentation/devicetree/bindings/mfd/max14577.txt | 147 ----------------
 Documentation/devicetree/bindings/mfd/max77802.txt |  25 ---
 .../devicetree/bindings/mfd/maxim,max14577.yaml    | 195 +++++++++++++++++++++
 .../devicetree/bindings/mfd/maxim,max77802.yaml    | 194 ++++++++++++++++++++
 .../devicetree/bindings/mfd/maxim,max77843.yaml    | 144 +++++++++++++++
 .../bindings/power/supply/maxim,max14577.yaml      |  84 +++++++++
 .../devicetree/bindings/regulator/max77802.txt     | 111 ------------
 .../bindings/regulator/maxim,max14577.yaml         |  78 +++++++++
 .../bindings/regulator/maxim,max77802.yaml         |  85 +++++++++
 .../bindings/regulator/maxim,max77843.yaml         |  65 +++++++
 .../bindings/soc/samsung/exynos-usi.yaml           |   2 +-
 .../bindings/spi/samsung,spi-peripheral-props.yaml |  33 ++++
 .../devicetree/bindings/spi/samsung,spi.yaml       | 187 ++++++++++++++++++++
 .../bindings/spi/spi-peripheral-props.yaml         |   1 +
 .../devicetree/bindings/spi/spi-samsung.txt        | 122 -------------
 MAINTAINERS                                        |   9 +-
 drivers/spi/spi-s3c64xx.c                          |  14 +-
 19 files changed, 1136 insertions(+), 431 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
 delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77843.yaml
 create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max14577.yaml
 delete mode 100644 Documentation/devicetree/bindings/regulator/max77802.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max14577.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77802.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77843.yaml
 create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi-peripheral-props.yaml
 create mode 100644 Documentation/devicetree/bindings/spi/samsung,spi.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog