[PATCH] openrisc: init: Add support for common clk

Stafford Horne posted 1 patch 4 years, 5 months ago
arch/openrisc/Kconfig       | 1 +
arch/openrisc/kernel/time.c | 4 ++++
2 files changed, 5 insertions(+)
[PATCH] openrisc: init: Add support for common clk
Posted by Stafford Horne 4 years, 5 months ago
When testing the new litex_mmc driver it was found to not work on
OpenRISC due to missing support for common clk.  This patch does the
basic initialization to allow OpenRISC to use the common clk framework.

Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/Kconfig       | 1 +
 arch/openrisc/kernel/time.c | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
index c2491b295d60..f724b3f1aeed 100644
--- a/arch/openrisc/Kconfig
+++ b/arch/openrisc/Kconfig
@@ -10,6 +10,7 @@ config OPENRISC
 	select ARCH_HAS_DMA_SET_UNCACHED
 	select ARCH_HAS_DMA_CLEAR_UNCACHED
 	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
+	select COMMON_CLK
 	select OF
 	select OF_EARLY_FLATTREE
 	select IRQ_DOMAIN
diff --git a/arch/openrisc/kernel/time.c b/arch/openrisc/kernel/time.c
index a6e69386f82a..6d18989d63d0 100644
--- a/arch/openrisc/kernel/time.c
+++ b/arch/openrisc/kernel/time.c
@@ -20,6 +20,7 @@
 #include <linux/clockchips.h>
 #include <linux/irq.h>
 #include <linux/io.h>
+#include <linux/of_clk.h>
 
 #include <asm/cpuinfo.h>
 
@@ -169,4 +170,7 @@ void __init time_init(void)
 
 	openrisc_timer_init();
 	openrisc_clockevent_init();
+
+	of_clk_init(NULL);
+	timer_probe();
 }
-- 
2.31.1

Re: [PATCH] openrisc: init: Add support for common clk
Posted by Geert Uytterhoeven 4 years, 5 months ago
Hi Stafford,

On Tue, Jan 11, 2022 at 4:01 AM Stafford Horne <shorne@gmail.com> wrote:
> When testing the new litex_mmc driver it was found to not work on
> OpenRISC due to missing support for common clk.  This patch does the
> basic initialization to allow OpenRISC to use the common clk framework.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Thanks for your patch!

This matches what other architectures are doing, and is IMHO the way
forward for sharing FPGA drivers among architectures.
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH] openrisc: init: Add support for common clk
Posted by Stafford Horne 4 years, 5 months ago
On Tue, Jan 11, 2022 at 05:31:05PM +0100, Geert Uytterhoeven wrote:
> Hi Stafford,
> 
> On Tue, Jan 11, 2022 at 4:01 AM Stafford Horne <shorne@gmail.com> wrote:
> > When testing the new litex_mmc driver it was found to not work on
> > OpenRISC due to missing support for common clk.  This patch does the
> > basic initialization to allow OpenRISC to use the common clk framework.
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> 
> Thanks for your patch!
> 
> This matches what other architectures are doing, and is IMHO the way
> forward for sharing FPGA drivers among architectures.
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thank you.

-Stafford