[v1] net: phy: marvell: add Marvell specific PHY loopback

[PATCH net 0/1] net: phy: marvell: add Marvell specific PHY loopback

Posted by Mohammad Athari Bin Ismail 4 years, 5 months ago

This patch to implement Marvell PHY specific loopback callback function.
Verified working on Marvell 88E1510 at 1Gbps speed only. For 100Mbps and
10Mbps, found that the PHY loopback not able to function properly.
Possible due to limitation in Marvell 88E1510 PHY.

Tested on Intel Elkhart Lake platform (Synopsys Designware QoS MAC and
Marvell 88E1510 PHY).

Mohammad Athari Bin Ismail (1):
  net: phy: marvell: add Marvell specific PHY loopback

 drivers/net/phy/marvell.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.17.1

Re: [PATCH net 0/1] net: phy: marvell: add Marvell specific PHY loopback

Posted by Russell King (Oracle) 4 years, 5 months ago

On Mon, Jan 10, 2022 at 02:21:16PM +0800, Mohammad Athari Bin Ismail wrote:
> This patch to implement Marvell PHY specific loopback callback function.
> Verified working on Marvell 88E1510 at 1Gbps speed only. For 100Mbps and
> 10Mbps, found that the PHY loopback not able to function properly.
> Possible due to limitation in Marvell 88E1510 PHY.

This is valuable information that should be in the commit message for
the patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

RE: [PATCH net 0/1] net: phy: marvell: add Marvell specific PHY loopback

Posted by Ismail, Mohammad Athari 4 years, 5 months ago


> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Monday, January 10, 2022 5:36 PM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Andrew Lunn <andrew@lunn.ch>; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Oleksij
> Rempel <linux@rempel-privat.de>; Heiner Kallweit
> <hkallweit1@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH net 0/1] net: phy: marvell: add Marvell specific PHY
> loopback
> 
> On Mon, Jan 10, 2022 at 02:21:16PM +0800, Mohammad Athari Bin Ismail
> wrote:
> > This patch to implement Marvell PHY specific loopback callback function.
> > Verified working on Marvell 88E1510 at 1Gbps speed only. For 100Mbps
> > and 10Mbps, found that the PHY loopback not able to function properly.
> > Possible due to limitation in Marvell 88E1510 PHY.
> 
> This is valuable information that should be in the commit message for the
> patch.

Sure. I will add this information in commit message for next version patch.

-Athari-

> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!