[PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const

Colin Ian King posted 1 patch 4 years, 5 months ago
drivers/net/wireless/st/cw1200/wsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const
Posted by Colin Ian King 4 years, 5 months ago
Don't populate the read-only array queue_id_to_wmm_aci on the stack
but instead make it static. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/st/cw1200/wsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/st/cw1200/wsm.c b/drivers/net/wireless/st/cw1200/wsm.c
index 99624dd34886..5a3e7a626702 100644
--- a/drivers/net/wireless/st/cw1200/wsm.c
+++ b/drivers/net/wireless/st/cw1200/wsm.c
@@ -537,7 +537,7 @@ int wsm_set_tx_queue_params(struct cw1200_common *priv,
 {
 	int ret;
 	struct wsm_buf *buf = &priv->wsm_cmd_buf;
-	u8 queue_id_to_wmm_aci[] = {3, 2, 0, 1};
+	static const u8 queue_id_to_wmm_aci[] = { 3, 2, 0, 1 };
 
 	wsm_cmd_lock(priv);
 
-- 
2.32.0

Re: [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const
Posted by Kalle Valo 4 years, 5 months ago
Colin Ian King <colin.i.king@gmail.com> wrote:

> Don't populate the read-only array queue_id_to_wmm_aci on the stack
> but instead make it static. Also makes the object code a little smaller.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Patch applied to wireless-next.git, thanks.

fe683faecc7a cw1200: wsm: make array queue_id_to_wmm_aci static const

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220109230921.58766-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches