mtd: spi-nor: Add support for w25q512jvm

[PATCH] mtd: spi-nor: Add support for w25q512jvm

Posted by Dhananjay Phadke 4 years, 5 months ago

Add support for Winbond 64MB W25Q512JV-DTR NOR flash.
Use PARSE_SFDP flag to init parameters during SFDP parsing.

Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
---
 drivers/mtd/spi-nor/winbond.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 675f32c136b3..ebc826e21f76 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -118,6 +118,8 @@ static const struct flash_info winbond_parts[] = {
 		.fixups = &w25q256_fixups },
 	{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512)
 		PARSE_SFDP },
+	{ "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
+		PARSE_SFDP },
 	{ "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
-- 
2.25.1

Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

Posted by Pratyush Yadav 4 years, 5 months ago

Hi Dhananjay,

On 08/01/22 08:44PM, Dhananjay Phadke wrote:
> Add support for Winbond 64MB W25Q512JV-DTR NOR flash.
> Use PARSE_SFDP flag to init parameters during SFDP parsing.
> 
> Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
> ---

You need to show the dumps of the SFDP and other flash parameters. See 
[0] for an example.

The patch looks fine to me otherwise.

[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/20211209190436.401946-2-tudor.ambarus@microchip.com/

>  drivers/mtd/spi-nor/winbond.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 675f32c136b3..ebc826e21f76 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -118,6 +118,8 @@ static const struct flash_info winbond_parts[] = {
>  		.fixups = &w25q256_fixups },
>  	{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512)
>  		PARSE_SFDP },
> +	{ "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> +		PARSE_SFDP },
>  	{ "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },
> -- 
> 2.25.1
> 

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

Posted by Michael Walle 4 years, 5 months ago

Hi,

Am 2022-01-09 05:44, schrieb Dhananjay Phadke:
> Add support for Winbond 64MB W25Q512JV-DTR NOR flash.
> Use PARSE_SFDP flag to init parameters during SFDP parsing.
> 
> Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c 
> b/drivers/mtd/spi-nor/winbond.c
> index 675f32c136b3..ebc826e21f76 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -118,6 +118,8 @@ static const struct flash_info winbond_parts[] = {
>  		.fixups = &w25q256_fixups },
>  	{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512)
>  		PARSE_SFDP },
> +	{ "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),

OTP_INFO(256, 3, 0x1000, 0x1000)

should enable OTP support, could you please test this using the 
flash_otp_{dump,info,erase,write} tools and add that line?

> +		PARSE_SFDP },
>  	{ "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },

-michael

Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

Posted by Dhananjay Phadke 4 years, 5 months ago

On 1/10/2022 7:10 AM, Michael Walle wrote:
>
>> +    { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> 
> OTP_INFO(256, 3, 0x1000, 0x1000)
> 
> should enable OTP support, could you please test this using the 
> flash_otp_{dump,info,erase,write} tools and add that line?

The board I've has HW filter between controller and NOR and doesn't seem 
to allow security reg access opcodes (read to be specific).

So long as adding this doesn't affect probe, I can add it. Otherwise, 
will have to leave it for later when that's fixed.

On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
>
> You need to show the dumps of the SFDP and other flash parameters. See
> [0] for an example.
>
> The patch looks fine to me otherwise.
>

Lemme collect SFDP dump and include it in v2.
I ended up sending stale patch that has extra comma between INFO() 
PARSE_SFDP macros, so need to re-spin anyway.

Thanks,
Dhananjay

Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

Posted by Pratyush Yadav 4 years, 5 months ago

On 10/01/22 03:12PM, Dhananjay Phadke wrote:
> On 1/10/2022 7:10 AM, Michael Walle wrote:
> > 
> > > +    { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> > 
> > OTP_INFO(256, 3, 0x1000, 0x1000)
> > 
> > should enable OTP support, could you please test this using the
> > flash_otp_{dump,info,erase,write} tools and add that line?
> 
> The board I've has HW filter between controller and NOR and doesn't seem to
> allow security reg access opcodes (read to be specific).
> 
> So long as adding this doesn't affect probe, I can add it. Otherwise, will
> have to leave it for later when that's fixed.

Please don't it if you can't test it. In that case let's just leave it 
for someone else to add later.

> 
> 
> On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
> > 
> > You need to show the dumps of the SFDP and other flash parameters. See
> > [0] for an example.
> > 
> > The patch looks fine to me otherwise.
> > 
> 
> Lemme collect SFDP dump and include it in v2.
> I ended up sending stale patch that has extra comma between INFO()
> PARSE_SFDP macros, so need to re-spin anyway.
> 
> Thanks,
> Dhananjay

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.