sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
Current timeout is simply too low. Since blowing fuses is a
very rare operation, so the risk associated with overestimating this
number is low.
Increase fuse blow timeout from 1ms to 10ms.

Signed-off-by: Knox Chiou <knoxchiou@chromium.org>
---

 drivers/nvmem/qfprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index c500d6235bf6b..1840d400fb53c 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -22,7 +22,7 @@
 
 /* Amount of time required to hold charge to blow fuse in micro-seconds */
 #define QFPROM_FUSE_BLOW_POLL_US	100
-#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
+#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
 
 #define QFPROM_BLOW_STATUS_OFFSET	0x048
 #define QFPROM_BLOW_STATUS_BUSY		0x1
-- 
2.34.1.448.ga2b2bfdf31-goog

Hi,

On Thu, Jan 6, 2022 at 6:31 PM Knox Chiou <knoxchiou@chromium.org> wrote:
>
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
>
> Signed-off-by: Knox Chiou <knoxchiou@chromium.org>
> ---
>
>  drivers/nvmem/qfprom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Slight nit that ${SUBJECT} for patches usually doesn't end with a
period. Presumably if Srinivas cares he can fix it while applying.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Srinivas

On Fri, Jan 7, 2022 at 6:57 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Thu, Jan 6, 2022 at 6:31 PM Knox Chiou <knoxchiou@chromium.org> wrote:
> >
> > sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> > Current timeout is simply too low. Since blowing fuses is a
> > very rare operation, so the risk associated with overestimating this
> > number is low.
> > Increase fuse blow timeout from 1ms to 10ms.
> >
> > Signed-off-by: Knox Chiou <knoxchiou@chromium.org>
> > ---
> >
> >  drivers/nvmem/qfprom.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Slight nit that ${SUBJECT} for patches usually doesn't end with a
> period. Presumably if Srinivas cares he can fix it while applying.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

I noticed that this patch still isn't in linux-next. Did it get lost,
or are you waiting for anything additional before applying?

Thanks!

-Doug

On Thu, Jan 6, 2022 at 6:31 PM Knox Chiou <knoxchiou@chromium.org> wrote:
>
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
>
> Signed-off-by: Knox Chiou <knoxchiou@chromium.org>

Reviewed-by: Evan Green <evgreen@chromium.org>

On 07/01/2022 02:31, Knox Chiou wrote:
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
> 
> Signed-off-by: Knox Chiou <knoxchiou@chromium.org>

Applied thanks,

--srini
> ---
> 
>   drivers/nvmem/qfprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index c500d6235bf6b..1840d400fb53c 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -22,7 +22,7 @@
>   
>   /* Amount of time required to hold charge to blow fuse in micro-seconds */
>   #define QFPROM_FUSE_BLOW_POLL_US	100
> -#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
> +#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
>   
>   #define QFPROM_BLOW_STATUS_OFFSET	0x048
>   #define QFPROM_BLOW_STATUS_BUSY		0x1