dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

[PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

Posted by Rob Herring 4 years, 5 months ago

The '/bits/ 64' notation applies the next <> list of values. Another <> list
is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
with '/bits/ 64'.

While the dts format allows this, as a rule we don't mix sizes for DT
properties since all size information is lost in the dtb file.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index 0f79d9a01c49..722781aa4697 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -448,17 +448,17 @@ examples:
                         reg = <20>;
                         adi,sensor-type = <9>; //custom thermocouple
                         adi,single-ended;
-                        adi,custom-thermocouple = /bits/ 64
-                                 <(-50220000) 0>,
-                                 <(-30200000) 99100000>,
-                                 <(-5300000) 135400000>,
-                                 <0 273150000>,
-                                 <40200000 361200000>,
-                                 <55300000 522100000>,
-                                 <88300000 720300000>,
-                                 <132200000 811200000>,
-                                 <188700000 922500000>,
-                                 <460400000 1000000000>; //10 pairs
+                        adi,custom-thermocouple =
+                                 /bits/ 64 <(-50220000) 0>,
+                                 /bits/ 64 <(-30200000) 99100000>,
+                                 /bits/ 64 <(-5300000) 135400000>,
+                                 /bits/ 64 <0 273150000>,
+                                 /bits/ 64 <40200000 361200000>,
+                                 /bits/ 64 <55300000 522100000>,
+                                 /bits/ 64 <88300000 720300000>,
+                                 /bits/ 64 <132200000 811200000>,
+                                 /bits/ 64 <188700000 922500000>,
+                                 /bits/ 64 <460400000 1000000000>; //10 pairs
                };
 
         };
-- 
2.32.0

RE: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

Posted by Sa, Nuno 4 years, 5 months ago

> From: Rob Herring <robh@kernel.org>
> Sent: Friday, January 7, 2022 4:20 AM
> To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
> 
> [External]
> 
> The '/bits/ 64' notation applies the next <> list of values. Another <>
> list
> is encoded as 32-bits by default. IOW, each <> list needs to be
> preceeded
> with '/bits/ 64'.
> 
> While the dts format allows this, as a rule we don't mix sizes for DT
> properties since all size information is lost in the dtb file.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

Thanks!
- Nuno Sá

Re: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

Posted by Jonathan Cameron 4 years, 5 months ago

On Fri, 7 Jan 2022 15:01:29 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> > From: Rob Herring <robh@kernel.org>
> > Sent: Friday, January 7, 2022 4:20 AM
> > To: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>; Sa, Nuno
> > <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes
> > 
> > [External]
> > 
> > The '/bits/ 64' notation applies the next <> list of values. Another <>
> > list
> > is encoded as 32-bits by default. IOW, each <> list needs to be
> > preceeded
> > with '/bits/ 64'.
> > 
> > While the dts format allows this, as a rule we don't mix sizes for DT
> > properties since all size information is lost in the dtb file.
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>  
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>

Hi Rob,

Do you want me to pick these up, or as they are fixes would you rather take
them yourself to get them in quickly?

In case you want to pick this up.

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 
> Thanks!
> - Nuno Sá
>

Re: [PATCH] dt-bindings: iio: adi,ltc2983: Fix 64-bit property sizes

Posted by Rob Herring 4 years, 5 months ago

On Thu, 06 Jan 2022 21:20:26 -0600, Rob Herring wrote:
> The '/bits/ 64' notation applies the next <> list of values. Another <> list
> is encoded as 32-bits by default. IOW, each <> list needs to be preceeded
> with '/bits/ 64'.
> 
> While the dts format allows this, as a rule we don't mix sizes for DT
> properties since all size information is lost in the dtb file.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/iio/temperature/adi,ltc2983.yaml | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 

Applied, thanks!