dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example

[PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example

Posted by Rob Herring 4 years, 5 months ago

Best practice for multi-cell property values is to bracket each multi-cell
value.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
index 7b895784e008..57a31356082e 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
@@ -74,9 +74,9 @@ examples:
         compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
         adc {
             compatible = "ti,palmas-gpadc";
-            interrupts = <18 0
-                          16 0
-                          17 0>;
+            interrupts = <18 0>,
+                         <16 0>,
+                         <17 0>;
             #io-channel-cells = <1>;
             ti,channel0-current-microamp = <5>;
             ti,channel3-current-microamp = <10>;
-- 
2.32.0

Re: [PATCH] dt-bindings: iio/adc: ti,palmas-gpadc: Split interrupt fields in example

Posted by Jonathan Cameron 4 years, 5 months ago

On Thu,  6 Jan 2022 12:25:11 -0600
Rob Herring <robh@kernel.org> wrote:

> Best practice for multi-cell property values is to bracket each multi-cell
> value.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git.

I'm assuming there is no rush on this as it's best practice rather than a bug.

Thanks,

Jonathan

> ---
>  .../devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml        | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> index 7b895784e008..57a31356082e 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> @@ -74,9 +74,9 @@ examples:
>          compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
>          adc {
>              compatible = "ti,palmas-gpadc";
> -            interrupts = <18 0
> -                          16 0
> -                          17 0>;
> +            interrupts = <18 0>,
> +                         <16 0>,
> +                         <17 0>;
>              #io-channel-cells = <1>;
>              ti,channel0-current-microamp = <5>;
>              ti,channel3-current-microamp = <10>;