Drivers: hv: vmbus: Initialize request offers message for Isolation VM

[PATCH] Drivers: hv: vmbus: Initialize request offers message for Isolation VM

Posted by Juan Vazquez 4 years, 5 months ago

Initialize memory of request offers message to be sent to the host so
padding or uninitialized fields do not leak guest memory contents.

Signed-off-by: Juan Vazquez <juvazq@linux.microsoft.com>
---
 drivers/hv/channel_mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 2829575fd9b7..60375879612f 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -1554,7 +1554,7 @@ int vmbus_request_offers(void)
 	struct vmbus_channel_msginfo *msginfo;
 	int ret;
 
-	msginfo = kmalloc(sizeof(*msginfo) +
+	msginfo = kzalloc(sizeof(*msginfo) +
 			  sizeof(struct vmbus_channel_message_header),
 			  GFP_KERNEL);
 	if (!msginfo)
-- 
2.32.0

Re: [PATCH] Drivers: hv: vmbus: Initialize request offers message for Isolation VM

Posted by Wei Liu 4 years, 5 months ago

On Wed, Jan 05, 2022 at 11:27:46AM -0800, Juan Vazquez wrote:
> Initialize memory of request offers message to be sent to the host so
> padding or uninitialized fields do not leak guest memory contents.
> 
> Signed-off-by: Juan Vazquez <juvazq@linux.microsoft.com>

Applied to hyperv-next. Thanks.

> ---
>  drivers/hv/channel_mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 2829575fd9b7..60375879612f 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -1554,7 +1554,7 @@ int vmbus_request_offers(void)
>  	struct vmbus_channel_msginfo *msginfo;
>  	int ret;
>  
> -	msginfo = kmalloc(sizeof(*msginfo) +
> +	msginfo = kzalloc(sizeof(*msginfo) +
>  			  sizeof(struct vmbus_channel_message_header),
>  			  GFP_KERNEL);
>  	if (!msginfo)
> -- 
> 2.32.0
>