[RFC PATCH] ACPI: PCC: pcc_ctx can be static

kernel test robot posted 1 patch 4 years, 5 months ago
acpi_pcc.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[RFC PATCH] ACPI: PCC: pcc_ctx can be static
Posted by kernel test robot 4 years, 5 months ago
drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 acpi_pcc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
index 64552fdb73470..9df4d740b52a6 100644
--- a/drivers/acpi/acpi_pcc.c
+++ b/drivers/acpi/acpi_pcc.c
@@ -31,7 +31,7 @@ struct pcc_data {
 	struct acpi_pcc_info ctx;
 };
 
-struct acpi_pcc_info pcc_ctx;
+static struct acpi_pcc_info pcc_ctx;
 
 static void pcc_rx_callback(struct mbox_client *cl, void *m)
 {
Re: [RFC PATCH] ACPI: PCC: pcc_ctx can be static
Posted by Sudeep Holla 4 years, 5 months ago
Hi,

On Thu, Jan 06, 2022 at 01:45:56AM +0800, kernel test robot wrote:
> drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>

Thanks for the fix and sorry for not noticing this before it was merged.

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep
Re: [RFC PATCH] ACPI: PCC: pcc_ctx can be static
Posted by Rafael J. Wysocki 4 years, 5 months ago
On Thu, Jan 6, 2022 at 3:12 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Hi,
>
> On Thu, Jan 06, 2022 at 01:45:56AM +0800, kernel test robot wrote:
> > drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not declared. Should it be static?
> >
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Thanks for the fix and sorry for not noticing this before it was merged.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

Applied, thanks!