HID: hid-uclogic-params: Fix NULL pointer dereferences

[PATCH 0/4] HID: hid-uclogic-params: Fix NULL pointer dereferences

Posted by José Expósito 4 years, 5 months ago

Hi everyone,

This series fixes 4 possible NULL pointer dereference errors
present in hid-uclogic-params.c found by Coverity.

Even though the fixes are small and very similar I made them
in 4 patches to include the Coverity ID on each of them and
make Coverity happy.

I didn't find any code calling the functions with invalid
params, but since the check is there, it's better to make sure
that it's doing its job.

Thanks,
José Expósito

José Expósito (4):
  HID: hid-uclogic-params: Invalid parameter check in
    uclogic_params_init
  HID: hid-uclogic-params: Invalid parameter check in
    uclogic_params_get_str_desc
  HID: hid-uclogic-params: Invalid parameter check in
    uclogic_params_huion_init
  HID: hid-uclogic-params: Invalid parameter check in
    uclogic_params_frame_init_v1_buttonpad

 drivers/hid/hid-uclogic-params.c | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

-- 
2.25.1

Re: [PATCH 0/4] HID: hid-uclogic-params: Fix NULL pointer dereferences

Posted by Jiri Kosina 4 years, 5 months ago

On Wed, 5 Jan 2022, José Expósito wrote:

> Hi everyone,
> 
> This series fixes 4 possible NULL pointer dereference errors
> present in hid-uclogic-params.c found by Coverity.
> 
> Even though the fixes are small and very similar I made them
> in 4 patches to include the Coverity ID on each of them and
> make Coverity happy.
> 
> I didn't find any code calling the functions with invalid
> params, but since the check is there, it's better to make sure
> that it's doing its job.

Thanks, I've queued the series.

-- 
Jiri Kosina
SUSE Labs