drivers/platform/chrome/cros_ec_lpc.c | 47 ++++++++++----- include/linux/platform_data/cros_ec_commands.h | 4 + 2 files changed, 38 insertions(+), 13 deletions(-)
This patch series adds support for the Framework Laptop to the cros_ec LPC driver. The Framework Laptop is a non-Chromebook laptop that uses the ChromeOS Embedded Controller. Since the machine was designed to present a more normal device profile, it does not report all 512 I/O ports that are typically used by cros_ec_lpcs. Because of this, changes to the driver's port reservation scheme were required. Dustin L. Howett (2): platform/chrome: cros-ec: detect the Framework Laptop platform/chrome: reserve only the I/O ports required for the MEC EC drivers/platform/chrome/cros_ec_lpc.c | 47 ++++++++++----- include/linux/platform_data/cros_ec_commands.h | 4 + 2 files changed, 38 insertions(+), 13 deletions(-) -- 2.34.1
Hi Dustin, On Tue, Jan 04, 2022 at 09:12:40PM -0600, Dustin L. Howett wrote: > This patch series adds support for the Framework Laptop to the cros_ec > LPC driver. > > The Framework Laptop is a non-Chromebook laptop that uses the ChromeOS > Embedded Controller. Since the machine was designed to present a more > normal device profile, it does not report all 512 I/O ports that are > typically used by cros_ec_lpcs. Because of this, changes to the driver's > port reservation scheme were required. > > Dustin L. Howett (2): > platform/chrome: cros-ec: detect the Framework Laptop > platform/chrome: reserve only the I/O ports required for the MEC EC > > drivers/platform/chrome/cros_ec_lpc.c | 47 ++++++++++----- > include/linux/platform_data/cros_ec_commands.h | 4 + > 2 files changed, 38 insertions(+), 13 deletions(-) > Thanks for sending this! I saw that Framework also posted their embedded controller source code as well, so we've got both sides of this process in the open now! I'd like to have someone else at Google ramp up on reviewing chrome/platform patches. Tzung-Bi, could you help take a look at Dustin's series? Thanks, Benson > -- > 2.34.1 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
Hi Benson, On Tue, Jan 25, 2022 at 4:52 AM Benson Leung <bleung@google.com> wrote: > Tzung-Bi, could you help take a look at Dustin's series? Pardon me, I didn't subscribe LKML due to it is too noisy. Could you also forward the 2 patches? I will try some magic (https://chromium.googlesource.com/chromiumos/docs/+/HEAD/kernel_development.md#Downloading-a-patch-from-patchwork-into-IMAP) to get the mail thread. And subscribe LKML to get further patch series.
If nothing else helps, you should be able to find and download the series from lore.kernel.org/lkml (https://lore.kernel.org/lkml/?q=%22framework+laptop%22). Long term it might be useful to set up patchwork to track cros related patches. Guenter On Mon, Jan 24, 2022 at 5:13 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > Hi Benson, > > On Tue, Jan 25, 2022 at 4:52 AM Benson Leung <bleung@google.com> wrote: > > Tzung-Bi, could you help take a look at Dustin's series? > > Pardon me, I didn't subscribe LKML due to it is too noisy. Could you > also forward the 2 patches? > > I will try some magic > (https://chromium.googlesource.com/chromiumos/docs/+/HEAD/kernel_development.md#Downloading-a-patch-from-patchwork-into-IMAP) > to get the mail thread. And subscribe LKML to get further patch > series.
Hi Guenter, On Tue, Jan 25, 2022 at 8:52 AM Guenter Roeck <groeck@google.com> wrote: > > If nothing else helps, you should be able to find and download the > series from lore.kernel.org/lkml > (https://lore.kernel.org/lkml/?q=%22framework+laptop%22). Long term it > might be useful to set up patchwork to track cros related patches. I've inquired about creating a patchwork for chrome/platform. Definitely agree that this could be organized better. Benson > > Guenter > > On Mon, Jan 24, 2022 at 5:13 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > > > Hi Benson, > > > > On Tue, Jan 25, 2022 at 4:52 AM Benson Leung <bleung@google.com> wrote: > > > Tzung-Bi, could you help take a look at Dustin's series? > > > > Pardon me, I didn't subscribe LKML due to it is too noisy. Could you > > also forward the 2 patches? > > > > I will try some magic > > (https://chromium.googlesource.com/chromiumos/docs/+/HEAD/kernel_development.md#Downloading-a-patch-from-patchwork-into-IMAP) > > to get the mail thread. And subscribe LKML to get further patch > > series. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
© 2016 - 2026 Red Hat, Inc.