[PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness

Lukas Bulwahn posted 1 patch 4 years, 5 months ago
drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness
Posted by Lukas Bulwahn 4 years, 5 months ago
The referred config BIG_ENDIAN does not exist. The config for the
endianness of the CPU architecture is called CPU_BIG_ENDIAN.

Correct the config name to the existing config for the endianness.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 1b73647cc3b1..8c01123dc4ed 100644
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -662,7 +662,7 @@ static int i3c_hci_init(struct i3c_hci *hci)
 
 	/* Make sure our data ordering fits the host's */
 	regval = reg_read(HC_CONTROL);
-	if (IS_ENABLED(CONFIG_BIG_ENDIAN)) {
+	if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
 		if (!(regval & HC_CONTROL_DATA_BIG_ENDIAN)) {
 			regval |= HC_CONTROL_DATA_BIG_ENDIAN;
 			reg_write(HC_CONTROL, regval);
-- 
2.17.1

Re: [PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness
Posted by Nicolas Pitre 4 years, 5 months ago
On Mon, 3 Jan 2022, Lukas Bulwahn wrote:

> The referred config BIG_ENDIAN does not exist. The config for the
> endianness of the CPU architecture is called CPU_BIG_ENDIAN.
> 
> Correct the config name to the existing config for the endianness.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Nicolas Pitre <npitre@baylibre.com>

> ---
>  drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 1b73647cc3b1..8c01123dc4ed 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -662,7 +662,7 @@ static int i3c_hci_init(struct i3c_hci *hci)
>  
>  	/* Make sure our data ordering fits the host's */
>  	regval = reg_read(HC_CONTROL);
> -	if (IS_ENABLED(CONFIG_BIG_ENDIAN)) {
> +	if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
>  		if (!(regval & HC_CONTROL_DATA_BIG_ENDIAN)) {
>  			regval |= HC_CONTROL_DATA_BIG_ENDIAN;
>  			reg_write(HC_CONTROL, regval);
> -- 
> 2.17.1
> 
> 
Re: [PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness
Posted by Alexandre Belloni 4 years, 5 months ago
On Mon, 3 Jan 2022 10:45:04 +0100, Lukas Bulwahn wrote:
> The referred config BIG_ENDIAN does not exist. The config for the
> endianness of the CPU architecture is called CPU_BIG_ENDIAN.
> 
> Correct the config name to the existing config for the endianness.
> 
> 

Applied, thanks!

[1/1] i3c/master/mipi-i3c-hci: correct the config reference for endianness
      commit: 7a2bccd1a27f0c8fc87e4ed56abd6ea9fa7314a6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>